Add IDE controller support for CDROMs #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wengier <wengierwu@yahoo.com> Co-authored-by: Jonathan Campbell <jonathan@castus.tv>
Also moves assignment of the (base-class) IDEDevice "type" into its constructor as a required argument.
Authored-by: Wengier <wengierwu@yahoo.com>
- No longer derive the controller class from Module. - Adds a function "get_or_create_controller" that manages - Use a std::array to manage the active IDE controllers
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you, @Wengier , for porting this many months ago!
This adds an
-ideflag toimgmount.comthat can be used when mounting CDROM image files, which as iso or bin+cue files.This is useful for games that both require a real DOS environment (and therefore must use a bootable HDD image) and also require particular CDROM drive access. Examples of this includes European Racers by Revell, Inc (and their other games of similar style).