Merge pull request #56 from tolbahadi/feat/locale/updateHtmlLangAttr

Update the lang attribute of the html tag when the locale changes
doshprompt · Aug 18, 2015 · ee1fff3 · ee1fff3
2 parents 1ce1284 + db2c2d2
commit ee1fff3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/localization.js b/src/localization.js
@@ -2,6 +2,7 @@ angular.module('ngLocalize')
     .service('locale', function ($injector, $http, $q, $log, $rootScope, $window, localeConf, localeEvents, localeSupported, localeFallbacks) {
         var TOKEN_REGEX = new RegExp('^[\\w\\.-]+\\.[\\w\\s\\.-]+\\w(:.*)?$'),
 
+            $html = angular.element(document.body).parent(),
             currentLocale,
             deferrences,
             bundles,
@@ -227,6 +228,12 @@ angular.module('ngLocalize')
             return result;
         }
 
+        function updateHtmlTagLangAttr(lang) {
+            lang = lang.split('-')[0];
+
+            $html.attr('lang', lang);
+        }
+
         function setLocale(value) {
             var lang;
 
@@ -249,6 +256,8 @@ angular.module('ngLocalize')
                 deferrences = {};
                 currentLocale = lang;
 
+                updateHtmlTagLangAttr(lang);
+
                 $rootScope.$broadcast(localeEvents.localeChanges, currentLocale);
                 $rootScope.$broadcast(localeEvents.resourceUpdates);
 

diff --git a/tests/unit/serviceSpec.js b/tests/unit/serviceSpec.js
@@ -35,5 +35,10 @@ describe('service', function () {
         it('should validate tokens with whitespace', inject(function (locale) {
             expect(locale.isToken('test.hello world')).toBe(true);
         }));
+
+        it('should update the lang attribute of the html tag', inject(function (locale) {
+            locale.setLocale('en-US');
+            expect(angular.element(document.body).parent().attr('lang')).toBe('en');
+        }));
     });
 });