Update the lang attribute of the html tag when the locale changes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolbahadi
changed the title
<html>s lang attribute
|
Oops! I thought |
tolbahadi
force-pushed
the
feat/locale/updateHtmlLangAttr
branch
from
9d7e06c
to
96bddc2
Compare
| @@ -227,6 +228,12 @@ angular.module('ngLocalize') | |||
| return result; | |||
| } | |||
|
|
|||
| function updateHtmlTagLangAttr(lang) { | |||
| lang = lang.replace(/\-.+/, ''); | |||
Angular-localization will now update the `lang` attribute of the root `html` tag to match the current locale's language This closes doshprompt#22 because users can now use the lang attribute in their css to change the direction of the document and/or add any other language specific css Example: ```css html[lang=ar] { direction: rtl; } ```
tolbahadi
force-pushed
the
feat/locale/updateHtmlLangAttr
branch
from
96bddc2
to
db2c2d2
Compare
|
PR updated by the way. |
doshprompt
added a commit
that referenced
this pull request
Aug 18, 2015
Update the lang attribute of the html tag when the locale changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular-localization will now update the
langattributeof the root
htmltag to match the current locale's languageThis closes #22 because users can now use the lang
attribute in their css to change the direction of the
document and/or add any other language specific css
Example: