Import screen should not be auto-selecting Key Fields that can't be de-selected

[DeanGonzalez]

Tested on 4.2.1 and 4.2.2

The import screen is automatically selecting key fields - which should not happen for ANY fields.

Secondly, the fields are not de-selectable, forcing the import file to always match and update where the auto-selected keyfields match

This bug breaks the ability to import content correctly in the majority of cases

[oarrietadotcms]

Seems like that has been the behavior since the beginning. This is from demo3:

This is the source code that disables the items:

core/dotCMS/src/main/webapp/html/portlet/ext/contentlet/import_contentlets.jsp

Lines 75 to 102 in 74cbca5

	function fieldCheckbox (field) {
	var fieldName = field["fieldName"];
	var fieldInode = field["inode"];
	var fieldIndexed = field["fieldIndexed"];
	var disableField = "";
	if(!fieldIndexed){
	disableField = "disabled"
	}
	<%
	String[] fields = form.getFields();
	for (int i = 0; i < fields.length; i++)
	{
	%>
	if ((fieldInode == "<%=fields[i]%>") && fieldIndexed) {
	if (dijit.byId(fieldInode + 'Field'))
	dijit.byId(fieldInode + 'Field').destroy();
	return "<div class='checkbox'><input checked type=\"checkbox\" dojoType=\"dijit.form.CheckBox\" id=\"" + fieldInode + "Field\" name=\"fields\" value=\"" + fieldInode + "\" "+disableField+" /> " + fieldName + "</div>";
	}
	<%
	}
	%>
	if (dijit.byId(fieldInode + 'Field'))
	dijit.byId(fieldInode + 'Field').destroy()
	return "<div class='checkbox'><input type=\"checkbox\" dojoType=\"dijit.form.CheckBox\" id=\"" + fieldInode + "Field\" name=\"fields\" value=\"" + fieldInode + "\" "+disableField+" /> <label>" + fieldName + "</label></div>";
	}

Are we really sure that this is a bug?

[DeanGonzalez]

Definitely a bug, when we remove that the fields are required... the import keyfields are still there. I just removed all required fields from the employee content type on demo:

Then try to import content, and you still get this:

Not sure when we busted this, but definitely wrong.

[wezell]

@dean is this just a visual bug, meaning they have a grayed out checkbox but they are not selected or used? Or does it affect the system behavior?

[oarrietadotcms]

@wezell @DeanGonzalez for what I see in the source code, they are only disabled (visually). Nothing related to its value.

And also this happens only for NOT INDEXED fields.

[oarrietadotcms]

My guess is that UI prevents selecting a NOT-INDEXED field as a key field. Makes sense, right?

[wezell]

Yeah - the bug is that the disabled state looks checked .

[DeanGonzalez]

Yep, it is just visual bug, it actually allows it, even though it looks like it won't... not as bad as I thought, even though still a bug.

[stale]

This issue has been automatically marked as stale because it has not had activity within the past 90 days. It will be closed in 30 days no further activity occurs. Thank you.