Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mislead message thrown when trying to create a new language with wrong values #13168

Closed
nollymar opened this issue Dec 4, 2017 · 2 comments
Closed

Mislead message thrown when trying to create a new language with wrong values #13168

nollymar opened this issue Dec 4, 2017 · 2 comments
Labels
Merged QA : Passed Internal Release : 5.1.0
Milestone
5.0_081418_REX

Comments

@nollymar
Copy link
Contributor

nollymar commented Dec 4, 2017 •
edited

An incorrect message and an exception are thrown if a user types unexpected values for fields when a new language is created, ie. type a language name in the Language Code field.

create_language

Log error: https://gist.github.com/nollymar/dbb8ea4857a3945291b91cebda722f6b
Wrong message: "Language Not Saved. There is already another Language with the same Language code and Country code."

Your Environment

  • dotCMS version used: dotCMS 4.2.x
  • Browser Name and version: Google Chrome
  • Operating System and version: MacOS
  • Application Server and version: Tomcat8
  • Java Brand and version: JDK 8
  • Database and version: Postgres
  • Application module (if apply): Languages
@dsilvam dsilvam changed the title Exception thrown when trying to create a new language Exception thrown when trying to create a new language with wrong values Dec 4, 2017
@dsilvam dsilvam changed the title Exception thrown when trying to create a new language with wrong values Mislead message thrown when trying to create a new language with wrong values Dec 4, 2017
@dsilvam dsilvam added this to the Rex Next milestone Dec 4, 2017
@dsilvam dsilvam modified the milestones: Rex Current , Rex Next Jan 16, 2018
@dsilvam dsilvam modified the milestones: Rex Current, Rex Next Feb 13, 2018
@dsilvam dsilvam modified the milestones: Rex Current, Rex Next Mar 1, 2018
@dsilvam dsilvam modified the milestones: Rex Current, Rex Next Mar 20, 2018
@erickgonzalez erickgonzalez modified the milestones: Rex Current, Rex Next Apr 11, 2018
@dsilvam dsilvam modified the milestones: Rex Current, Rex Next May 1, 2018
erickgonzalez added a commit that referenced this issue Aug 8, 2018
@erickgonzalez
#13168 add maxLength property to LanguageCode and CountryCode
fbdaf90
@erickgonzalez
Copy link
Contributor

PR: #15082

@erickgonzalez erickgonzalez modified the milestones: Rex Backlog, Rex Current Aug 9, 2018
dsilvam pushed a commit that referenced this issue Aug 9, 2018
@erickgonzalez @dsilvam
#13168 add maxLength property to LanguageCode and CountryCode (#15082)
1583660
@nollymar nollymar self-assigned this Aug 9, 2018
@nollymar nollymar removed their assignment Aug 9, 2018
@nollymar
Copy link
Contributor Author

nollymar commented Aug 9, 2018

Tests Results: OK. The fix is working as expected

@wezell wezell closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Passed Internal Release : 5.1.0
Projects
None yet
Milestone
5.0_081418_REX
Development

No branches or pull requests
4 participants
@wezell @dsilvam @erickgonzalez @nollymar