Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete failed records from dist_reindex_journal before a full reindex #16664

Open
nollymar opened this issue Jun 3, 2019 · 5 comments

Comments

@nollymar
Copy link
Contributor

commented Jun 3, 2019

All failed records must be removed from the dist_reindex_journal table before running a full reindex to avoid the reindex process gets stuck.

Additionally, when a reindex entry (that does not belong to any piece of content) cannot be reindexed, it must be logged as debug and deleted from the dist_reindex_journal to avoid unnecessary attempts

@nollymar nollymar added this to the Rex Current milestone Jun 3, 2019

@nollymar nollymar self-assigned this Jun 3, 2019

@nollymar nollymar changed the title Delete failing records from dist_reindex_journal before a full reindex Delete failed records from dist_reindex_journal before a full reindex Jun 3, 2019

@bryanboza bryanboza added this to REX in QA Jun 3, 2019

nollymar added a commit that referenced this issue Jun 3, 2019

@nollymar

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Implemented here: #16668

@nollymar nollymar removed their assignment Jun 3, 2019

dsilvam added a commit that referenced this issue Jun 3, 2019

Issue 16664 delete failing records from dist reindex journal before a…
… full reindex (#16668)

* #16664 Deleting failed reindex entries that do not belong to any piece of content

* #16664 Removing failed entries from dist_reindex_journal before a full reindex

dsilvam added a commit that referenced this issue Jun 3, 2019

Issue 16664 delete failing records from dist reindex journal before a…
… full reindex (#16668)

* #16664 Deleting failed reindex entries that do not belong to any piece of content

* #16664 Removing failed entries from dist_reindex_journal before a full reindex

@erickgonzalez erickgonzalez self-assigned this Jun 3, 2019

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Tested on 5.1.6 and it's working both cases:

  • Upload a new file asset (must be an image) and run a full reindex.
  • Copy a site, run a full reindex, delete the copied site, run a full reindex.
@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Tested both cases in master, working as well.

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Fixed, tested with the provided steps // release branch // FF

@bryanboza bryanboza moved this from Needs QA to Done in Release 5.1.6 Jun 4, 2019

@dsilvam dsilvam modified the milestones: 060419_REX, Rex Current Jun 7, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Fixed, tested on master // Postgres // FF

@bryanboza bryanboza added Passed QA and removed Needs QA labels Jun 11, 2019

@bryanboza bryanboza moved this from REX to Done in QA Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.