Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete failed records from dist_reindex_journal before a full reindex #16664

Closed
nollymar opened this issue Jun 3, 2019 · 5 comments
Closed

Delete failed records from dist_reindex_journal before a full reindex #16664

nollymar opened this issue Jun 3, 2019 · 5 comments
Labels
Merged QA : Approved QA : Passed Internal Release : 5.1.6 Type : Defect
Milestone
062519_REX

Comments

@nollymar
Copy link
Contributor

nollymar commented Jun 3, 2019 •
edited

All failed records must be removed from the dist_reindex_journal table before running a full reindex to avoid the reindex process gets stuck.

Additionally, when a reindex entry (that does not belong to any piece of content) cannot be reindexed, it must be logged as debug and deleted from the dist_reindex_journal to avoid unnecessary attempts
@nollymar nollymar added this to the Rex Current milestone Jun 3, 2019
@nollymar nollymar self-assigned this Jun 3, 2019
@nollymar nollymar changed the title Delete failing records from dist_reindex_journal before a full reindex Delete failed records from dist_reindex_journal before a full reindex Jun 3, 2019
@erickgonzalez erickgonzalez mentioned this issue Jun 3, 2019
Closed
nollymar added a commit that referenced this issue Jun 3, 2019
@nollymar
#16664 Deleting failed reindex entries that do not belong to any piec…
685ae0d 
…e of content
nollymar added a commit that referenced this issue Jun 3, 2019
@nollymar
#16664 Removing failed entries from dist_reindex_journal before a ful…
e7d16f7 
…l reindex
@nollymar
Copy link
Contributor Author

nollymar commented Jun 3, 2019

Implemented here: #16668

@nollymar nollymar removed their assignment Jun 3, 2019
dsilvam pushed a commit that referenced this issue Jun 3, 2019
@nollymar @dsilvam
Issue 16664 delete failing records from dist reindex journal before a…
476c243 
… full reindex (#16668)

* #16664 Deleting failed reindex entries that do not belong to any piece of content

* #16664 Removing failed entries from dist_reindex_journal before a full reindex
dsilvam pushed a commit that referenced this issue Jun 3, 2019
@nollymar @dsilvam
Issue 16664 delete failing records from dist reindex journal before a…
b8ce9e0 
… full reindex (#16668)

* #16664 Deleting failed reindex entries that do not belong to any piece of content

* #16664 Removing failed entries from dist_reindex_journal before a full reindex
@erickgonzalez erickgonzalez self-assigned this Jun 3, 2019
@erickgonzalez
Copy link
Contributor

Tested on 5.1.6 and it's working both cases:

  • Upload a new file asset (must be an image) and run a full reindex.
  • Copy a site, run a full reindex, delete the copied site, run a full reindex.

@erickgonzalez
Copy link
Contributor

Tested both cases in master, working as well.

@erickgonzalez erickgonzalez removed their assignment Jun 4, 2019
@bryanboza
Copy link
Member

Fixed, tested with the provided steps // release branch // FF

@dsilvam dsilvam modified the milestones: 060419_REX, Rex Current Jun 7, 2019
@bryanboza
Copy link
Member

Fixed, tested on master // Postgres // FF

@wezell wezell closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Approved QA : Passed Internal Release : 5.1.6 Type : Defect
Projects
None yet
Milestone
062519_REX
Development

No branches or pull requests
5 participants
@wezell @dsilvam @bryanboza @erickgonzalez @nollymar