HTMLPageAsset, Events and Vanity URLs override Contentlet.getTitle

[wezell]

dotCMS expects that every contentlet has a title. There is specific logic in the Contentlet object to generate a title if there is not one set, which will ultimately fall back to the content.id as the title if nothing else is found. This is important from a ui and overall content perspective.

Issues arise when content of different base types overrides the Contentlet.getTitle() method. With content of these types, it is possible to create a content object that returns null or "" when .getTitle() is called which can cause issues in the UI. We need to ensure that content of all types relies on the logic of Contentlet.getTitle().

To see the issue:

1. Create a new PageAssetType called "testing"
2. Uncheck "required" for the title field
3. in the browser, add a new page of type "testing" and leave the title blank.
4. go to the browser and try to open the folder where your new page is. You will get a JS error, as the js is expecting a title.

[jdotcms]

PR

[bryanboza]

Fixed, unable to reproduce after the changes, tested on master // Postgres // FF