Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D&D in WYSIWYG stop working #19018

Closed
fmontes opened this issue Jul 31, 2020 · 3 comments
Closed

D&D in WYSIWYG stop working #19018

fmontes opened this issue Jul 31, 2020 · 3 comments
Assignees
@fmontes
Labels
Merged QA : Approved QA : Passed Internal Release : 5.3.6 Type : Defect
Milestone
5.3.5_08112020_LUNIK

Comments

@fmontes
Copy link
Member

fmontes commented Jul 31, 2020

Describe the bug
The ability to D&D images into a WYSIWYG stop working

To Reproduce
Steps to reproduce the behavior:

  1. Go to edit a content with a WYSIWYG field
  2. D&D an imagen into the WYSIWYG field
  3. Nothing happen

Expected behavior
It should allow users to drop images and insert them

Acceptance Criteria

  1. Allow user to drop images in WYSIWYG fields
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
@fmontes fmontes added this to the Lunik Current milestone Jul 31, 2020
fmontes added a commit that referenced this issue Jul 31, 2020
@fmontes
#19018 D&D in WYSIWYG stop working
816cc96
fmontes added a commit to dotCMS/dotcms-dojo-theme that referenced this issue Jul 31, 2020
@fmontes
dotCMS/core#19018 D&D in WYSIWYG stop working
553fe5f
fmontes added a commit that referenced this issue Jul 31, 2020
@fmontes
#19018 D&D in WYSIWYG stop working (#19020)
6064972
@fmontes fmontes self-assigned this Jul 31, 2020
@nollymar nollymar added the Merged label Aug 3, 2020
@bryanboza
Copy link
Member

We need some work here:

  • If you drag and drop some file but don't select the specific folder we are uploading the asset, but we are not able to show the thumbnail, also we have a JS error on console
    image

fmontes added a commit that referenced this issue Aug 4, 2020
@fmontes
#19018 Set System Host as default selected
cce5552
fmontes added a commit that referenced this issue Aug 4, 2020
@fmontes
#19018 Set System Host as default selected
5f7ca94
fmontes added a commit that referenced this issue Aug 4, 2020
@fmontes
#19018 Set System Host as default selected (#19029)
fa5d099
@fmontes fmontes removed the Needs Work label Aug 4, 2020
@fmontes
Copy link
Member Author

fmontes commented Aug 4, 2020

I fix this by selections System Host by default, on dialog show.

@bryanboza
Copy link
Member

Fixed, tested on release-5.3.6 // Postgres // FF

@fmontes fmontes closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

Labels
Merged QA : Approved QA : Passed Internal Release : 5.3.6 Type : Defect
Projects
None yet
Milestone
5.3.5_08112020_LUNIK
Development

No branches or pull requests
4 participants
@fmontes @bryanboza @nollymar @hmoreras