-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ThreadPoolExecutor on the DotConcurrentFactory should have a name #20401
Comments
We need to, by default, make the DotConcurrentFactory queue unbounded as is the java default. We can message in the logs / warn if the queue grows to over a specific size, e.g. over 50k or 100k, but we should not error out. The queue size has bitten us a number of times already. |
See: #19006 (comment) |
Note: This fix basically just changes the default value. For existing systems, the solution is to change the value of |
I would suggest even higher, something like |
Currently when the ThreadPoolExecutor rejects a thread looks like:
ent.DotConcurrentException: Task java.util.concurrent.FutureTask@4f4d36fd rejected from java.util.concurrent.ThreadPoolExecutor@582bbe5[Running, pool size = 50, active threads = 50, queued tasks = 100, completed tasks = 45322]
at com.dotcms.concurrent.DotConcurrentFactory$DotConcurrentImpl.submit(DotConcurrentFactory.java:475) ~[dotcms_5.3.8_999999.jar:?]
That do not give us info about which pool is having the issue, including the name would be a bit easier
The text was updated successfully, but these errors were encountered: