Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class in rows are lost when you remove a row #20519

Closed
fishsmith opened this issue Jun 10, 2021 · 3 comments
Closed

Class in rows are lost when you remove a row #20519

fishsmith opened this issue Jun 10, 2021 · 3 comments
Labels
Changelog: Documented dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.8.7 Included in LTS patch release 5.3.8.7 Release : 21.06.3 Included in LTS patch release 21.06.3 Release : 21.08 Type : Defect

Comments

@fishsmith
Copy link
Collaborator

fishsmith commented Jun 10, 2021 •
edited

Describe the bug
Removing a row (columns that add up to 12 - I now we don't have real rows in the layout) the classes are lost for all rows below the one removed. (See video)

To Reproduce

  • Goto Edit Mode > Layout
  • Create multiple rows and add class to each row and Save
  • Remove a row from the layout
  • Results: all rows below lost their classes

Note: If you add a new row (which gets added last) and then move it up, the same thing happens.

Expected behavior
When you remove a row the class should stay for the remaining rows

Screenshots
https://drive.google.com/file/d/1K9kOLpDXfcpBTAxpy8aPbTy4qf3Sjopb/view?usp=sharing
@wezell wezell added this to the Maintenance Sprint milestone Jun 10, 2021
@wezell wezell modified the milestones: Maintenance Sprint, Scout Current Jun 22, 2021
@alfredo-dotcms alfredo-dotcms self-assigned this Jun 29, 2021
alfredo-dotcms added a commit to dotCMS/core-web that referenced this issue Jul 1, 2021
@alfredo-dotcms
dotCMS/core#20519 fix class-in-row-lost-when-removed-row-above
9107c05
nollymar pushed a commit to dotCMS/core-web that referenced this issue Jul 2, 2021
@alfredo-dotcms
dotCMS/core#20519 fix class-in-row-lost-when-removed-row-above (#1690)
5267888
@nollymar
Copy link
Contributor

nollymar commented Jul 2, 2021

PR: dotCMS/core-web#1690

@nollymar
Copy link
Contributor

Passed internal QA

@bryanboza
Copy link
Member

Fixed, tested on release-21.07 // Postgres // FF

@wezell wezell closed this as completed Jul 20, 2021
@jcastro-dotcms jcastro-dotcms added the LTS : Next Ticket that will be added to LTS label Aug 3, 2021
@swicken-dotcms swicken-dotcms added the Release : 21.06.3 Included in LTS patch release 21.06.3 label Aug 11, 2021
swicken-dotcms added a commit to dotCMS/core-web that referenced this issue Aug 11, 2021
@swicken-dotcms
dotCMS/core#20519 : Including code changes in the 21.06.2 LTS Release
2422e1d
@jcastro-dotcms jcastro-dotcms added LTS: Released and removed LTS : Next Ticket that will be added to LTS labels Dec 9, 2021
jcastro-dotcms added a commit to dotCMS/core-web that referenced this issue Dec 18, 2021
@jcastro-dotcms
dotCMS/core#20519 : Adding code changes to dotCMS 5.3.8.7 LTS release.
89d5d74
jcastro-dotcms added a commit that referenced this issue Dec 18, 2021
@jcastro-dotcms
#20519 : Adding code changes to dotCMS 5.3.8.7 LTS release.
8954861
@jcastro-dotcms jcastro-dotcms added Release : 5.3.8.7 Included in LTS patch release 5.3.8.7 and removed LTS: Released labels Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelog: Documented dotCMS : Admin Tools Merged QA : Approved QA : Passed Internal Release : 5.3.8.7 Included in LTS patch release 5.3.8.7 Release : 21.06.3 Included in LTS patch release 21.06.3 Release : 21.08 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@wezell @fishsmith @bryanboza @rweiner @erickgonzalez @nollymar @jcastro-dotcms @alfredo-dotcms @swicken-dotcms