Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Felix load/undeployed to be overridden by env vars #20601

Closed
wezell opened this issue Jun 28, 2021 · 2 comments · Fixed by #20592
Closed

Allow Felix load/undeployed to be overridden by env vars #20601

wezell opened this issue Jun 28, 2021 · 2 comments · Fixed by #20592
Labels
Changelog: Documented Merged QA : Approved QA : Passed Internal Release : 21.06 Type : Enhancement

Comments

@wezell
Copy link
Contributor

wezell commented Jun 28, 2021

Because of the way we load felix props - by reading all the property keys and then only adding the ones that start with felix. it is impossible to use env vars to override the felix.load and felix.undeployed folders in dotCMS.

We need to be able to override felix's undeundeployedploy and load directories

DOT_FELIX_UNDEPLOYED_DIR=/opt/dotcms/data/assets/felix/undeployed
DOT_FELIX_FILEINSTALL_DIR=/opt/dotcms/data/assets/felix/load
@wezell wezell added this to the Maintenance Sprint milestone Jun 28, 2021
wezell added a commit that referenced this issue Jun 28, 2021
@wezell
fixes #20601
d69d4b9
wezell added a commit that referenced this issue Jun 28, 2021
@wezell
#20601 allow felix config from env
3e37dc0
wezell added a commit that referenced this issue Jun 28, 2021
@wezell
#20601 allow felix config from env
1bb929a
dsilvam pushed a commit that referenced this issue Jun 29, 2021
@wezell
docker env changes (#20592)
71958e6 
* ROOT/srv/10-merge-docker-config.sh

* updating docker image, removing hazel by default

* removing hardcoded hazelcast deps

* fixes connection leak in ImportAuditUtil.java

* fixing the 8082 connectors

* #20601 allow felix config from env
dsilvam added a commit that referenced this issue Jun 29, 2021
@dsilvam
#20601 extract to sys-props
e937ce1
@dsilvam dsilvam linked a pull request Jun 29, 2021 that will close this issue
docker env changes #20592
Merged
@dsilvam
Copy link
Contributor

dsilvam commented Jun 30, 2021 •
edited

Passed Internal QA.

Setting the following env vars in docker-compose like this:

"DOT_FELIX_FELIX_UNDEPLOYED_DIR": '/tmp/felix/undeployed'
"DOT_FELIX_FELIX_FILEINSTALL_DIR": '/tmp/felix/load'

let both felix's load and undeployed to be overridden.

@bryanboza
Copy link
Member

Fixed, tested on release-21.06 // Postgres // FF

@john-thomas-dotcms john-thomas-dotcms added the LTS : Next Ticket that will be added to LTS label Jul 14, 2021
@wezell wezell closed this as completed Jul 14, 2021
@jcastro-dotcms jcastro-dotcms removed the LTS : Next Ticket that will be added to LTS label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelog: Documented Merged QA : Approved QA : Passed Internal Release : 21.06 Type : Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docker env changes dotCMS/core
6 participants
@wezell @dsilvam @bryanboza @rweiner @jcastro-dotcms @john-thomas-dotcms