Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMA should always expect UTF8 #20629

Closed
wezell opened this issue Jul 8, 2021 · 3 comments · Fixed by #20660
Closed

EMA should always expect UTF8 #20629

wezell opened this issue Jul 8, 2021 · 3 comments · Fixed by #20660
Labels
Changelog: Documented Merged QA : Approved QA : Passed Internal Release : 5.3.8.6 Included in LTS patch release 5.3.8.6 Release : 21.06.3 Included in LTS patch release 21.06.3 Release : 21.08 Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Jul 8, 2021

When we get a response from an EMA server, we should expect a UTF8 response and parse it as such. Otherwise, all that gets included in edit mode is the raw byte array.
@wezell wezell added this to the Maintenance Sprint milestone Jul 8, 2021
wezell added a commit that referenced this issue Jul 8, 2021
@wezell
#20629 parse response as UTF8
3a47c57
dsilvam added a commit that referenced this issue Jul 14, 2021
@dsilvam
#20629 parse response as UTF8
5ccce24
dsilvam added a commit that referenced this issue Jul 14, 2021
@dsilvam
#20629 parse response as UTF8 (#20660)
c5be087
@dsilvam dsilvam linked a pull request Jul 14, 2021 that will close this issue
#20629 parse response as UTF8 #20660
Merged
@john-thomas-dotcms john-thomas-dotcms added LTS : Next Ticket that will be added to LTS and removed Severity : Support Priority labels Jul 14, 2021
@victoralfaro-dotcms
Copy link
Contributor

Changed "Thank you" text at contact-us page for "Thanks" and data came in UTF-8:
image
For what is worth, added a breakpoint at EMAInterceptor to validate response form EMA was used to instance a String with UTF-8 charset.

@victoralfaro-dotcms victoralfaro-dotcms removed their assignment Jul 26, 2021
@wezell
Copy link
Contributor Author

wezell commented Jul 26, 2021 •
edited

Please also test with a UTF-8 language and characters, e.g. 百度一下，你就知道

@bryanboza
Copy link
Member

bryanboza commented Jul 29, 2021 •
edited

Fixed, tested with the requested parameter and still getting the same format
image

@wezell wezell closed this as completed Jul 29, 2021
jcastro-dotcms added a commit that referenced this issue Aug 15, 2021
@jcastro-dotcms
#20629 : Back-porting code changes to dotCMS 5.3.8.6 LTS release.
a9f3836
jcastro-dotcms added a commit that referenced this issue Aug 15, 2021
@jcastro-dotcms
#20629 : Back-porting code changes to dotCMS 21.06.2 LTS release.
e796f48
@jcastro-dotcms jcastro-dotcms removed the LTS : Next Ticket that will be added to LTS label Aug 15, 2021
@rweiner rweiner added Release : 21.06.3 Included in LTS patch release 21.06.3 Release : 5.3.8.6 Included in LTS patch release 5.3.8.6 labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changelog: Documented Merged QA : Approved QA : Passed Internal Release : 5.3.8.6 Included in LTS patch release 5.3.8.6 Release : 21.06.3 Included in LTS patch release 21.06.3 Release : 21.08 Type : Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#20629 parse response as UTF8 dotCMS/core
9 participants
@wezell @dsilvam @bryanboza @rweiner @erickgonzalez @nollymar @jcastro-dotcms @john-thomas-dotcms @victoralfaro-dotcms