Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostAPI method findAllFromDB relies on Name instead of VarName #21782

Closed
erickgonzalez opened this issue Feb 28, 2022 · 5 comments
Closed

HostAPI method findAllFromDB relies on Name instead of VarName #21782

erickgonzalez opened this issue Feb 28, 2022 · 5 comments
Assignees
@jcastro-dotcms
Labels
OKR : Customer Support Owned by Scott Release : 22.03.7 Included in LTS patch release 22.03.7 Team : Lunik Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

To Reproduce
Steps to reproduce the behavior:

  1. Change the Host ContentType name to Dotcms Host
  2. Navigate to the Sites Portlet
  3. It shows No Results.

Expected behavior
All calls should rely on VarName instead of the Content-Type name because the name can be modified. In this case, the Sites Portlet should load fine regardless of the name of the Content-Type.

Support Ticket: https://dotcms.zendesk.com/agent/tickets/106602
@jcastro-dotcms jcastro-dotcms mentioned this issue Mar 2, 2022
Closed
4 tasks
@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Mar 4, 2022
@oidacra
Copy link
Member

oidacra commented Mar 4, 2022

Hey team! Please add your planning poker estimate with ZenHub @fmontes @hmoreras @jdotcms @jcastro-dotcms @rjvelazco

@jcastro-dotcms
Copy link
Contributor

Fixed in ticket #21476

@erickgonzalez erickgonzalez reopened this Mar 24, 2022
@erickgonzalez
Copy link
Contributor Author

Let's keep it open to tracking changes and also to QA

@fmontes
Copy link
Member

fmontes commented Mar 28, 2022 •
edited

Fixed in ticket #21476

This doesn't apply anymore because this gets fixed in master and release-22.04

We need to talk to @erickgonzalez to see what version do we need to port this.

jcastro-dotcms added a commit that referenced this issue Mar 28, 2022
@jcastro-dotcms
#21782 : Use velocity_var_name column instead of name column.
60ba595 
NOTE TO DEVS: This PR is intended for ixing this issue in the LTS releases only, as new changes recently sent to master
@jcastro-dotcms jcastro-dotcms linked a pull request Mar 28, 2022 that will close this issue
#21782 : Use velocity_var_name column instead of name column. #21907
Closed
@fmontes
Copy link
Member

fmontes commented Mar 29, 2022

Patch for Support #21907

@fmontes fmontes closed this as completed Mar 29, 2022
@erickgonzalez erickgonzalez added Next LTS Release OKR : Customer Support Owned by Scott and removed LTS : Next Ticket that will be added to LTS labels Jun 5, 2023
erickgonzalez added a commit that referenced this issue Jun 6, 2023
@erickgonzalez
#21782 include in 22.03.7
cee1f56
@erickgonzalez erickgonzalez added the Release : 22.03.7 Included in LTS patch release 22.03.7 label Jun 16, 2023
@AndreyDotcms AndreyDotcms added Release : 23.01.4 Included in LTS patch release 23.01.4 and removed Release : 23.01.4 Included in LTS patch release 23.01.4 labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcastro-dotcms jcastro-dotcms

Labels
OKR : Customer Support Owned by Scott Release : 22.03.7 Included in LTS patch release 22.03.7 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#21782 : Use velocity_var_name column instead of name column. dotCMS/core
5 participants
@fmontes @oidacra @erickgonzalez @jcastro-dotcms @AndreyDotcms