Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table block #21991

Closed
Tracked by #21988
fmontes opened this issue Apr 8, 2022 · 3 comments
Closed
Tracked by #21988

Add table block #21991

fmontes opened this issue Apr 8, 2022 · 3 comments
Assignees
@hmoreras
Labels
QA : Approved QA : Passed Internal Release : 23.01 Team : Lunik Type : Enhancement

Comments

@fmontes
Copy link
Member

fmontes commented Apr 8, 2022 •
edited by jcastro-dotcms

Is your feature request related to a problem? Please describe.
As a user, I want to be able to create tables in the block editor.

Describe the solution you'd like
Users should select table block from the block menu as any other block.

Describe alternatives you've considered
N/A

Additional context

  • We need to figure it out how to handle column width in relative units

UI/UX

NOTE TO QA:

The contextual options for both creating the table and the cell options have changed since Freddy's video was created. Please double-check with @hmoreras to make sure those options are correct.

table-block-editor.mp4
@oidacra oidacra self-assigned this May 6, 2022
@oidacra oidacra removed their assignment May 9, 2022
@hmoreras hmoreras self-assigned this May 10, 2022
@hmoreras hmoreras self-assigned this Aug 24, 2022
@hmoreras hmoreras mentioned this issue Nov 22, 2022
Merged
fmontes pushed a commit that referenced this issue Dec 1, 2022
@hmoreras
#21991 Add table block (#23418)
902c5a1 
* table block

* clean up

* feedback

* cell background correction
@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Dec 13, 2022 •
edited

Internal QA: FAILED

  • Docker Image: 23.01_ca54c27a_SNAPSHOT

There's a specific scenario in which the arrow at the top-right corner of the cell disappears.

iqa-21991.mov

fmontes pushed a commit that referenced this issue Dec 26, 2022
@hmoreras
#21991 Add table block
a7ac141
@hmoreras hmoreras mentioned this issue Dec 27, 2022
Merged
@rjvelazco
Copy link
Contributor

Passed Internal QA.

Docker Image: 23.01_51bfb0af_SNAPSHOT

@bryanboza
Copy link
Member

Fixed, tested on release-23.01 // Docker // FF '

Image

@fmontes fmontes closed this as completed Jan 3, 2023
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmoreras hmoreras

Labels
QA : Approved QA : Passed Internal Release : 23.01 Team : Lunik Type : Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@fmontes @wezell @oidacra @bryanboza @jcastro-dotcms @hmoreras @rjvelazco