Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom templates should push with their page no matter the filter that is selected #22385

Closed
swicken-dotcms opened this issue Jun 9, 2022 · 4 comments · Fixed by #27444
Closed
Assignees
Labels

Comments

@swicken-dotcms
Copy link
Contributor

swicken-dotcms commented Jun 9, 2022

Describe the bug
Currently if you push a page with a custom template and select any filter that does not include templates, it will not push the custom template alongside the page. This can create errors and unexpected behaviour.

Reproduced on: 22.03/5.3.8
Related Ticket: https://dotcms.zendesk.com/agent/tickets/107395
2nd ticket: https://dotcms.zendesk.com/agent/tickets/113372

To Reproduce

  1. Set up a sender/receiver
  2. Create a new page on the sender with any template, then modify it's layout
  3. Push publish that page to the receiver with the filter 'Only Selected Items' selected.
  4. Try to open that page on the receiver, you will get the following error:
    image

This is because the custom template was not pushed alongside the page.

Expected behavior
Because custom templates only impact the selected page and cannot be pushed separately, then they should be pushed with the page regardless of the filter selected. Custom templates should be considered part of the page, including layout changes.

@stale
Copy link

stale bot commented Dec 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 27, 2022
@stale stale bot closed this as completed Jan 4, 2023
@swicken-dotcms swicken-dotcms added OKR : Customer Success Owned by Arno and removed stale labels Sep 26, 2023
@swicken-dotcms
Copy link
Contributor Author

Re-opening, this is still an issue.

@AndreyDotcms AndreyDotcms self-assigned this Jan 18, 2024
AndreyDotcms added a commit that referenced this issue Jan 26, 2024
AndreyDotcms added a commit that referenced this issue Jan 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2024
* #22385 fix, new method and tests

* #22385 feedback

* tests: log filterDescription

* tests: create filter if not exist

---------

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@dsolistorres
Copy link
Contributor

Internal QA passed: pages with custom layout push published with the filter 'Only Selected Items' include the custom template and can be edited on the receiver.

@josemejias11
Copy link

Approved: Tested on master_87ad624, Docker, macOS 13.0, FF v121.0.1

@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS Next LTS Release Shortlisted of issues that will be included in the upcoming LTS and removed LTS : Next Ticket that will be added to LTS labels Feb 23, 2024
erickgonzalez added a commit that referenced this issue Feb 28, 2024
@erickgonzalez erickgonzalez added the Release : 23.01.13 Included in LTS patch release 23.01.13 label Mar 4, 2024
erickgonzalez added a commit that referenced this issue Mar 5, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v6 Included in LTS patch release 23.10.24 v6 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants