-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content+Permission REST improvements #22993
Comments
jdotcms
added a commit
that referenced
this issue
Sep 29, 2022
jdotcms
added a commit
that referenced
this issue
Sep 30, 2022
jdotcms
added a commit
that referenced
this issue
Oct 31, 2022
jdotcms
added a commit
that referenced
this issue
Nov 2, 2022
jdotcms
added a commit
that referenced
this issue
Nov 2, 2022
jdotcms
added a commit
that referenced
this issue
Nov 2, 2022
jdotcms
added a commit
that referenced
this issue
Mar 13, 2023
jdotcms
added a commit
that referenced
this issue
Mar 14, 2023
jdotcms
added a commit
that referenced
this issue
Mar 14, 2023
jdotcms
added a commit
that referenced
this issue
Mar 14, 2023
nollymar
pushed a commit
that referenced
this issue
Mar 14, 2023
#23272) * #22993 sending the PR again since the previous is having a weird behavior on test * #22993 seems to exists a conflict since an unit test and it test have the same name * #22993 seems to exists a conflict since an unit test and it test have the same name * #22993 fixing an unit test issue * #22993 fixing save draft * #22993 adding fixes for curl test * #22993 adding fixes for curl test * #22993 adding fixes for curl test * #22993 adding fixes for curl test
oidacra
pushed a commit
that referenced
this issue
Mar 16, 2023
#23272) * #22993 sending the PR again since the previous is having a weird behavior on test * #22993 seems to exists a conflict since an unit test and it test have the same name * #22993 seems to exists a conflict since an unit test and it test have the same name * #22993 fixing an unit test issue * #22993 fixing save draft * #22993 adding fixes for curl test * #22993 adding fixes for curl test * #22993 adding fixes for curl test * #22993 adding fixes for curl test
nollymar
added
QA : Passed Internal
Release : 23.05
Needs QA
and removed
Release : 23.03
labels
Mar 20, 2023
For this issue we are ok with the specific scenarions, we will move the failing case to a new card in order to test the correct response codes in all the resource. #24627 |
Approved QA - Tested on 23.05_3650a5d0_SNAPSHOT // Docker // macOS 13.0 // FF v111.0 Failing test will be addressed in card #24627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Make the permissions work on every action
I found some details using System Workflow and this endpoint
PUT localhost:8080/api/v1/workflow/actions/fire
:This works:
but the other actions, like Save doesn't work:
If one permission fails to save, just write an error and continue with the rest
When passing the roles to permission, allow roles to be specified by Role Key (which for users is a userId) OR Role ID
You should be able to pass either a role's UUID or the Role Key for any role
Follow the Null, Empty Collection, Collection rule of our other dependencies
individualPermissions
is not specified (null) we should not do anything with permissionsindividualPermissions
is an empty map, we should wipe out all permissionsindividualPermissions
are specified, we replace all the permissions with the new listOriginally posted by @nollymar in #22418 (comment)
The text was updated successfully, but these errors were encountered: