Content detailed page throwing 404 when URL contains a trailing slash. #23276

muhammadfaizandotcms · 2022-11-01T12:28:20Z

Describe the bug

Content detailed page throwing 404 when URL contains a trailing slash.
Reproduced on 22.10
Related ticket: https://dotcms.zendesk.com/agent/tickets/108893

To Reproduce

https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis Works fine
https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis/ throws 404

Expected behavior

The detailed page should return the desired contentlet when a trailing slash exists

Additional context

This behavior works fine on 21.06., 5.3.8.

stale · 2022-12-31T14:34:49Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yolabingo · 2023-01-24T18:10:28Z

This Rule may suffice in many cases to preserve the trailing slash behavior of URL mapped content after an upgrade. It obviously could be onerous if too many paths need to be matched.

It provides a 301 HTTP redirect from
https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis/
to
https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis

Googlebot and friends respect 301 redirects so this will preserve SEO for any old URLs with trailing slashes that may be out in the wild.

waqasakramdot · 2023-04-20T12:50:08Z

Another ticket https://dotcms.zendesk.com/agent/tickets/111098

* Avoid the clash between IndexPages and UrlMaps cases.

* We created a IAm subtype enum to manage different page types instead of creating a new IAm type. * We use tuples to manage isPageAsset and resourceResolveType methods.

* New method has been created in order to avoid changes on third classes.

* Avoid the clash between IndexPages and UrlMaps cases. * We created a IAm subtype enum to manage different page types instead of creating a new IAm type. * We use tuples to manage isPageAsset and resourceResolveType methods. * resolvePageAssetSubtype method has been created in order to avoid changes on third classes that use isPageAsset method.

* Replacing new Tuple2<> constructor statements by Tuple.of() method. * Replacing condition NOT isPresent() by isEmpty method

* resolveResourceType method * resolvePageAssetSubType method

swicken-dotcms · 2023-05-19T13:55:28Z

Another ticket: https://dotcms.zendesk.com/agent/tickets/110282

* #23276 IAm subtypes have been included. * Avoid the clash between IndexPages and UrlMaps cases. * We created a IAm subtype enum to manage different page types instead of creating a new IAm type. * We use tuples to manage isPageAsset and resourceResolveType methods. * resolvePageAssetSubtype method has been created in order to avoid changes on third classes that use isPageAsset method. * #23276 Some improvements. * Replacing new Tuple2<> constructor statements by Tuple.of() method. * Replacing condition NOT isPresent() by isEmpty method * #23276 Refactoring resolvePageAssetSubtype * #23276 Some test have been added to CMSUrlUtil * resolveResourceType method * resolvePageAssetSubType method * #23276 Test documentation has been added. * #23276 Some unuseful code has been removed. * #23276 Some unuseful code has been removed. --------- Co-authored-by: daniel.colina <daniel.colina@dotcms.com> Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>

damen-dotcms · 2023-06-16T20:59:19Z

Nice! I saw this as an issue on our site while doing a crawl. (=

Yeah Google doesn't care if you have a / or not at the end of a URL. So we should just ignore that.

Doesn't matter if you have a / or not in the canonical URL either -- except to say that sometimes you have to write another bit of regex to get the crawls to line up if you have different canonical URLs -- so ideally we would just load the same consistent / or no / for canonical URLs between the pages.

We don't really need to 301 one to the other... Google views them both as the same URL. And... since it views the URL as the same, adding a 301 redirect can muddy things (A 301 from one identical page to the other can inflate the "hops" if we have any other redirects present.) So I think ideally they would both just load as a 200... But let me know when this is released on our demo site and I'll run some further scans to verify. @nollymar

I just closed #25264 as a dupe of this.

damen-dotcms · 2023-06-16T21:07:04Z

Yeah OK, so doing another test...

It's really not good to 404 on the / since if we have any links that have a / that Google finds... it'll record the 404 as being on the page -- it doesn't care if there is a / or no slash, it sees the URLs as identical.

https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis
https://demo.dotcms.com/store/products/k2-mens-mindbender-99ti-skis/

But also, 301 from / to no slash seems OK... as long as there are no other 301s ahead in the "chain" and as long as the final version of the page shows a 200.

But yeah, I think ideally... both should just give a 200. No redirect needed. As long as the Canonical URLs are identical (but again, that's just to be kind to people doing crawls so they don't have to write any regex to sort out the different URLs).

nollymar · 2023-06-30T15:11:44Z

@damen-dotcms both urls give a 200 code, but this change is not yet released. It will be for the next release.

Internal QA: passed

Tested on master.

josemejias11 · 2023-07-03T18:14:11Z

Approved QA - Tested on master_b295876_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

muhammadfaizandotcms added Type : Defect Severity : Support Requested labels Nov 1, 2022

stale bot added the stale label Dec 31, 2022

erickgonzalez removed the stale label Jan 2, 2023

damen-dotcms added the OKR : Customer Support Owned by Scott label Feb 2, 2023

swicken-dotcms removed the Severity : Support Requested label Feb 6, 2023

erickgonzalez removed the Maintenance Sprint label Feb 6, 2023

swicken-dotcms added the Priority : 2 High label Mar 1, 2023

erickgonzalez added the Team : Scout label Mar 21, 2023

nollymar assigned dcolina Apr 25, 2023

dcolina pushed a commit that referenced this issue Apr 27, 2023

#23276 INDEX_PAGE type has been created to manage a new use case.

215531d

* Avoid the clash between IndexPages and UrlMaps cases.

dcolina pushed a commit that referenced this issue Apr 27, 2023

#23276 Remove some unused import.

bbcb902

dcolina pushed a commit that referenced this issue Apr 28, 2023

#23276 Refactor previous solution.

fa3d6e8

* We created a IAm subtype enum to manage different page types instead of creating a new IAm type. * We use tuples to manage isPageAsset and resourceResolveType methods.

dcolina pushed a commit that referenced this issue May 3, 2023

#23276 code improvements (solution refactor).

524aaf0

* New method has been created in order to avoid changes on third classes.

dcolina mentioned this issue May 3, 2023

Issue 23276 content detailed page not found #24814

Closed

dcolina mentioned this issue May 3, 2023

Issue 23276 urlmapping content detailed page not found #24822

Merged

dcolina pushed a commit that referenced this issue May 4, 2023

#23276 Some improvements.

ee6bc69

* Replacing new Tuple2<> constructor statements by Tuple.of() method. * Replacing condition NOT isPresent() by isEmpty method

dcolina pushed a commit that referenced this issue May 8, 2023

#23276 Refactoring resolvePageAssetSubtype

908022f

dcolina pushed a commit that referenced this issue May 18, 2023

#23276 Some test have been added to CMSUrlUtil

ba19df4

* resolveResourceType method * resolvePageAssetSubType method

erickgonzalez added the OKR : Customer Success Owned by Arno label May 19, 2023

dcolina pushed a commit that referenced this issue May 19, 2023

#23276 Test documentation has been added.

dec33fc

dcolina pushed a commit that referenced this issue May 19, 2023

#23276 Some unuseful code has been removed.

40e6218

dcolina pushed a commit that referenced this issue May 22, 2023

#23276 Some unuseful code has been removed.

dca22e6

nollymar closed this as completed in #24822 May 25, 2023

nollymar reopened this May 25, 2023

nollymar unassigned dcolina May 25, 2023

nollymar added Merged QA : Needs Internal Release : 23.08.16 labels May 25, 2023

damen-dotcms mentioned this issue Jun 16, 2023

dotCMS should not resolve a 404 if URLs have a trailing "/" #25264

Closed

nollymar added QA : Passed Internal and removed QA : Needs Internal labels Jun 30, 2023

josemejias11 added the QA : Approved label Jul 3, 2023

erickgonzalez added the Next LTS Release label Jul 11, 2023

jdcmsd added the Release : 23.07 label Jul 17, 2023

erickgonzalez added a commit that referenced this issue Jul 19, 2023

#23276 include in 23.01.5

7a68d25

erickgonzalez added a commit that referenced this issue Jul 31, 2023

#23276 include in 22.03.8

daf9f94

AndreyDotcms added the Release : 22.03.8 Included in LTS patch release 22.03.8 label Jul 31, 2023

erickgonzalez closed this as completed Aug 1, 2023

erickgonzalez added Release : 23.01.5 Included in LTS patch release 23.01.5 and removed Next LTS Release Release : 23.08.16 labels Aug 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Content detailed page throwing 404 when URL contains a trailing slash. #23276

Content detailed page throwing 404 when URL contains a trailing slash. #23276

muhammadfaizandotcms commented Nov 1, 2022 •

edited

stale bot commented Dec 31, 2022

yolabingo commented Jan 24, 2023 •

edited

waqasakramdot commented Apr 20, 2023

swicken-dotcms commented May 19, 2023

damen-dotcms commented Jun 16, 2023 •

edited

damen-dotcms commented Jun 16, 2023

nollymar commented Jun 30, 2023

josemejias11 commented Jul 3, 2023 •

edited

Content detailed page throwing 404 when URL contains a trailing slash. #23276

Content detailed page throwing 404 when URL contains a trailing slash. #23276

Comments

muhammadfaizandotcms commented Nov 1, 2022 • edited

Describe the bug

To Reproduce

Expected behavior

Additional context

stale bot commented Dec 31, 2022

yolabingo commented Jan 24, 2023 • edited

waqasakramdot commented Apr 20, 2023

swicken-dotcms commented May 19, 2023

damen-dotcms commented Jun 16, 2023 • edited

damen-dotcms commented Jun 16, 2023

nollymar commented Jun 30, 2023

josemejias11 commented Jul 3, 2023 • edited

muhammadfaizandotcms commented Nov 1, 2022 •

edited

yolabingo commented Jan 24, 2023 •

edited

damen-dotcms commented Jun 16, 2023 •

edited

josemejias11 commented Jul 3, 2023 •

edited