Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers: Add support for file containers #23798

Closed
Tracked by #23140
fmontes opened this issue Jan 12, 2023 · 5 comments · Fixed by #24094
Closed
Tracked by #23140

Containers: Add support for file containers #23798

fmontes opened this issue Jan 12, 2023 · 5 comments · Fixed by #24094
Assignees
@rjvelazco
Labels
OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.05 Team : Lunik Type : Enhancement Type : Refactoring

Comments

@fmontes
Copy link
Member

fmontes commented Jan 12, 2023 •
edited

Is your feature request related to a problem? Please describe.

In dotCMS we have 3 types of containers:

  1. System: user can't edit it
  2. DB: Are the ones we create with the UI and the containers API
  3. FILE: containers that are creating by adding a set of files in the file system.

Currently, we're not correctly supporting the FILE type.

Describe the solution you'd like

  1. List of the file containers
  2. The row of a file container should have the url
  3. The row of a file container should NOT have:
    • Checkbox or be able to be selected
    • Three dots actions buttons
    • Be able to apply actions to
  4. When the user clicks the row of a file container, it should link to the Site Browser with the containers folder opened (currently working in the JSP containers)
  5. The containers API response have a "source" : "FILE" property to indicate the type of container.

Additional context

Original containers

Screenshot 2023-01-12 at 11 30 27

Figma
https://www.figma.com/file/k1LhfC4OxI4ZQr2erCFhKM/Portlets-%2F-Containers?node-id=1%3A209&t=mUxKSmLeBzbVAqOr-1

‼️ To view file containers, run dotCMS with the full starter

Acceptance criteria

  • List the file containers
  • System containers always on top
  • When user clicks the file container row it should go to the site browser with the containers opened
  • User should not be able to run actions on file containers
@zulqarnainvd zulqarnainvd self-assigned this Jan 25, 2023
zulqarnainvd added a commit that referenced this issue Jan 26, 2023
@zulqarnainvd
#23798 remove actions on file containers and update test case
cef585b
zulqarnainvd added a commit that referenced this issue Jan 26, 2023
@zulqarnainvd
#23798 fix permissions load issue
f3f5cf2
fmontes pushed a commit that referenced this issue Jan 26, 2023
@zulqarnainvd
#23798 fix permissions load issue (#23909)
a9bfca3
zulqarnainvd added a commit that referenced this issue Feb 14, 2023
@zulqarnainvd
#23798 fixed file container selection and redirection issue adn add t…
e42f17e 
…est cases
zulqarnainvd added a commit that referenced this issue Feb 14, 2023
@zulqarnainvd
#23798 fixed path issue
e56fc53
zulqarnainvd added a commit that referenced this issue Feb 14, 2023
@zulqarnainvd
#23798 remove typo
2eb1f07
zulqarnainvd added a commit that referenced this issue Feb 14, 2023
@zulqarnainvd
#23798 fix dropdown clear issue on filter
8b8d99d
fmontes pushed a commit that referenced this issue Feb 14, 2023
@zulqarnainvd
#23443 Allow filter by content types in the containers endpoint (#24107)
66f18ad 
* #23798 fix dropdown clear issue on filter

* #23443 fix typo
zulqarnainvd added a commit that referenced this issue Feb 15, 2023
@zulqarnainvd
#23798 remove system containers from list and addressed PR feedback
a3945c3
zulqarnainvd added a commit that referenced this issue Feb 16, 2023
@zulqarnainvd
#23798 fix test case
b155e89
fmontes pushed a commit that referenced this issue Feb 25, 2023
@zulqarnainvd
#23798 Containers: Add support for file containers (#24094)
494f2e8 
* #23798 remove actions on file containers and update test case

* #23798 fixed file container selection and redirection issue adn add test cases

* #23798 fixed path issue

* #23798 remove typo

* #23798 remove system containers from list and addressed PR feedback

* #23798 fix test case
@fmontes fmontes linked a pull request Feb 25, 2023 that will close this issue
dotCMS/core#23798 Containers: Add support for file containers #24094
Merged
3 tasks
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
@rjvelazco
Copy link
Contributor

rjvelazco commented Mar 2, 2023 •
edited

Failed Internal QA.

Docker image: [dotcms/dotcms:master_bd915908]

We are adding a double // a the beginning of the URL. That's not part of the Figma design which only has one.

Figma Design Old Portlet New Portlet
Image Image Image

Note:

In the New Portlet, the File Containers are at the ends while in the Figma Design and the Old Portlet they are at the beginning.

@fmontes
Copy link
Member Author

fmontes commented Mar 7, 2023

Is ok, we are ref a host.

@josemejias11
Copy link

Failed QA - Tested on 23.05_646c3cbf_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

Screen.Recording.2023-04-05.at.3.07.08.PM.mov
  1. When the user clicks the row of a file container, it should link to the Site Browser with the containers folder opened

@jcastro-dotcms jcastro-dotcms mentioned this issue Apr 14, 2023
Closed
@jcastro-dotcms
Copy link
Contributor

@josemejias11 , as per discussion with the Lunik Team, this issue happens in our Demo Site as well. I have created a new ticket in order to address the redirect issue: #24644

@josemejias11
Copy link

Approved QA - Tested on 23.05_14850342_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

@fmontes fmontes closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
OKR : Core Features Owned by Will QA : Approved QA : Passed Internal Release : 23.05 Team : Lunik Type : Enhancement Type : Refactoring
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dotCMS/core#23798 Containers: Add support for file containers dotCMS/core
5 participants
@fmontes @jcastro-dotcms @rjvelazco @zulqarnainvd @josemejias11