Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Tomcat logging config settings to Docker Env vars #24067

Closed
yolabingo opened this issue Feb 9, 2023 · 2 comments · Fixed by #24079
Closed

Add additional Tomcat logging config settings to Docker Env vars #24067

yolabingo opened this issue Feb 9, 2023 · 2 comments · Fixed by #24079

Comments

@yolabingo
Copy link
Contributor

yolabingo commented Feb 9, 2023

Parent Issue

We expose some Tomcat access log config options as Docker env vars e.g. CMS_ACCESSLOG_PATTERN
There are a few more logging options we should provide.

Task

Dockerfile template change

Proposed Objective

Cloud Engineering

Proposed Priority

Priority 3 - Average

Acceptance Criteria

Involves minor changes to templates in our dotcms Dockerfile

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/109957

Assumptions & Initiation Needs

None

Sub-Tasks & Estimates

None

@yolabingo yolabingo changed the title Add additional logging config settings to Docker Env vars Add additional Tomcat logging config settings to Docker Env vars Feb 9, 2023
@nollymar nollymar reopened this Mar 15, 2023
@dcolina
Copy link
Contributor

dcolina commented Mar 16, 2023

It was tested locally after building the ROOT docker image. Worked as expected.

As follow:

  1. Build ROOT docker image from branch (issue-24067-docker-logs-env-vars)
  2. Change CMS_ACCESSLOG_DIRECTORY value to test_log_directory
  3. Raise the application through docker-compose
  4. Run bash inside the container of dotCMS (created by docker-compose)
  5. Verify the access log directory has the name defined in CMS_ACCESSLOG_DIRECTORY variable.

@dcolina dcolina removed their assignment Mar 16, 2023
@dsilvam dsilvam removed the Needs QA label Mar 21, 2023
@josemejias11
Copy link

Approved QA - Tested on 23.05_4cd0d90a_SNAPSHOT // Docker // macOS 13.0 // FF v112.0.1

Screenshot 2023-04-25 at 12 34 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants