Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Keys API throws 400 when a duplicate key exists #24082

Closed
muhammadfaizandotcms opened this issue Feb 10, 2023 · 2 comments · Fixed by #26689
Closed

Language Keys API throws 400 when a duplicate key exists #24082

muhammadfaizandotcms opened this issue Feb 10, 2023 · 2 comments · Fixed by #26689
Assignees
Labels
OKR : Customer Support Owned by Scott QA : Approved Release : 22.03.14 Included in LTS patch release 22.03.14 Release : 23.01.11 Included in LTS patch release 23.01.11 Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@muhammadfaizandotcms
Copy link

Problem Statement

Language Keys API throws 400 when a duplicate key exists.
Relevant Ticket: https://dotcms.zendesk.com/agent/tickets/109737.
Reproduced in 23.01
API: https://demo.dotcms.com/api/v2/languages/default/keys.
Response: {"message":"Duplicate key dot.check.text (attempted merging values Value and Value)"}

Steps to Reproduce

  1. log in to the demo site.
  2. Go to Content types and click on Language Variable content type.
  3. Edit the value field and make it non-unique.
  4. now go to content->search portlet and create multiple contentlets of Language Variable with the same key (dot.check.text).
  5. Now login to the demo site using the Cognito tab and see the response of Language keys API.
  6. It's throwing 400.

Acceptance Criteria

API: https://demo.dotcms.com/api/v2/languages/default/keys.
Language API should not break when there is a duplicate key.
In 23.01 we can't add the same key twice for a language but it will create problems for the customers who will upgrade from old environments.

dotCMS Version

23.01

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Screenshot from 2023-02-10 17-23-31

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response

@wezell
Copy link
Contributor

wezell commented Nov 15, 2023

PR: #26689

@erickgonzalez erickgonzalez self-assigned this Nov 16, 2023
@erickgonzalez erickgonzalez reopened this Nov 20, 2023
@josemejias11
Copy link

Approved: Tested on master_13c2337_SNAPSHOT, Docker, macOS 13.0, FF v113.0

@bryanboza bryanboza added the Release : 23.12.21 SEO Improvements label Dec 22, 2023
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Jan 8, 2024
erickgonzalez added a commit that referenced this issue Jan 8, 2024
@erickgonzalez erickgonzalez added the Release : 22.03.14 Included in LTS patch release 22.03.14 label Jan 12, 2024
erickgonzalez added a commit that referenced this issue Jan 16, 2024
@erickgonzalez erickgonzalez added the Release : 23.01.11 Included in LTS patch release 23.01.11 label Jan 22, 2024
erickgonzalez added a commit that referenced this issue Jan 25, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 and removed Next LTS Release labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OKR : Customer Support Owned by Scott QA : Approved Release : 22.03.14 Included in LTS patch release 22.03.14 Release : 23.01.11 Included in LTS patch release 23.01.11 Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants