"(Default)" marker in Site Search interferes with reindexing

[jdcmsd]

Problem Statement

In the Alias Name input field under Dev Tools → Site Search → Job Scheduler, it notes which index is the default by adding (Default) to the end of it. However, this is treated as part of the input value, and furthermore contains invalid characters, resulting in this error on an attempted reindex of a default index:

This is solvable by manually deleting the "(Default)" text.

Steps to Reproduce

1. On Demo, go to Dev Tools → Site Search.
2. Create an index in either of the following ways:
   1. Under Indices, click Create Site Search Index and enter the name test
   2. Or: under Job Scheduler, set the following values:
      • Run: Now
      • Check the Index All Sites box
      • Select all languages
      • Enter the Alias Name test
3. Now that you have an index, ensure it is set to the Default state.
   • If it is not the default, then under Indices, right-click it and pick Make default.
     
4. Go to Job Scheduler and enter the parameters given above: Run/Now, Index All Sites, all languages. However, leave the Alias Name field as it appears with the test (Default) text, or select it from the dropdown if it is not already present.
5. Click Schedule, see error.
   

After this, delete (Default) from the input, leaving just test, and then click Schedule again. The job should schedule properly.

Acceptance Criteria

We should accept the (Default) value.

dotCMS Version

Tested on 23.02, 22.09.

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response

[jdcmsd]

If I'm understanding correctly, this solution should make it possible for the index to be saved with the (Default) it adds. But then the next time you run the job, wouldn't it list the index name as test(Default) (Default), and then test(Default)(Default) (Default), and so on?

[erickgonzalez]

@jdcmsd No, the name is kept as test (Default)

[josemejias11]

Approved QA - Tested on master_86f6fb2b_SNAPSHOT // Docker // macOS 13.0 // FF v113.0