Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Stats displays incorrect TTL for Caffine Memory Cache regions using default "indefinite" TTL #24199

Closed
yolabingo opened this issue Feb 23, 2023 · 4 comments · Fixed by #24212
Closed

Cache Stats displays incorrect TTL for Caffine Memory Cache regions using default "indefinite" TTL #24199

yolabingo opened this issue Feb 23, 2023 · 4 comments · Fixed by #24212
Assignees
@jdotcms
Labels
OKR : Core Features Owned by Will QA : Approved Release : 23.05 Team : Lunik Type : Defect

Comments

@yolabingo
Copy link
Contributor

yolabingo commented Feb 23, 2023 •
edited

Parent Issue

No response

Problem Statement

Cache stats displays "100s" for cache regions using the default TTL, which is incorrect. The default TTL is basically forever - INTEGER.MAX seconds.

Screenshot 2023-02-23 at 2 17 28 PM

When setting a custom TTL, for example
DOT_CACHE_CONTENTLETCACHE_SECONDS: '456'
the custom TTL value is correctly displayed.

Steps to Reproduce

Log into demo.dotcms.com

Settings -> Maintenance -> Cache -> Refresh Stats

Acceptance Criteria

Display correct TTL in Cache Stats

dotCMS Version

All supported versions

Proposed Objective

Core Features

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.slack.com/archives/CSHTYUR7H/p1677180023116509

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@yolabingo
Copy link
Contributor Author

@jdotcms

@yolabingo yolabingo changed the title Cache Stats displays incorrect TTL for Caffine Memory Cache regions Cache Stats displays incorrect TTL for Caffine Memory Cache regions using default "indefinite" TTL Feb 23, 2023
@jdotcms jdotcms self-assigned this Feb 24, 2023
jdotcms added a commit that referenced this issue Feb 24, 2023
@jdotcms
#24199 minor change to show infinity when there is max ttl time
c460d25
@jdotcms
Copy link
Contributor

jdotcms commented Feb 24, 2023

PR

@jdotcms jdotcms linked a pull request Feb 24, 2023 that will close this issue
#24199 minor change to show infinity when there is max ttl time #24212
Merged
fmontes pushed a commit that referenced this issue Mar 14, 2023
@jdotcms
Fix #24199 minor change to show infinity when there is max ttl time (#…
5117298 
…24212)
oidacra pushed a commit that referenced this issue Mar 16, 2023
@jdotcms @oidacra
Fix #24199 minor change to show infinity when there is max ttl time (#…
6c7c6b8 
…24212)
@jcastro-dotcms jcastro-dotcms self-assigned this Mar 30, 2023
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

Cache Regions with unlimited size are now displaying the word "infinity", like this:

Screen Shot 2023-03-30 at 8 31 23 AM

@jcastro-dotcms jcastro-dotcms removed their assignment Mar 30, 2023
@bryanboza
Copy link
Member

Fixed, after the change now we are showing infinity in some specific cache regions.

Tested on release-23.05 // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdotcms jdotcms

Labels
OKR : Core Features Owned by Will QA : Approved Release : 23.05 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#24199 minor change to show infinity when there is max ttl time dotCMS/core
6 participants
@yolabingo @fmontes @bryanboza @jcastro-dotcms @jdotcms @damen-dotcms