Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested dotcache causes issues #24247

Closed
erickgonzalez opened this issue Mar 1, 2023 · 3 comments · Fixed by #24274
Closed

Nested dotcache causes issues #24247

erickgonzalez opened this issue Mar 1, 2023 · 3 comments · Fixed by #24274
Assignees
@erickgonzalez
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott Priority : 1 Show Stopper QA : Not Needed Release : 23.01.1 Included in LTS patch release 23.01.1 Release : 23.05 Team : Bug Fixers Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

Parent Issue

#24075

Problem Statement

Nested dotcache blocks cause some pages don't load successfully since it's caching the wrong context.

Steps to Reproduce

Ask support for customer data.

Acceptance Criteria

Pages should render successfully even with nested dotcache blocks

dotCMS Version

23.01

Proposed Objective

Customer Support

Proposed Priority

Priority 1 - Show Stopper

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Customer Ticket: https://dotcms.zendesk.com/agent/tickets/110078

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@erickgonzalez
Copy link
Contributor Author

The code that broke this was included in 23.01.

@erickgonzalez erickgonzalez self-assigned this Mar 1, 2023
erickgonzalez added a commit that referenced this issue Mar 1, 2023
@erickgonzalez
#24247 include in 23.01.1
a6cb714
erickgonzalez added a commit that referenced this issue Mar 3, 2023
@erickgonzalez
#24247 if ttl is 0 it means no cache, use new StringWriter
d5e3580
@erickgonzalez erickgonzalez linked a pull request Mar 3, 2023 that will close this issue
#24247 if ttl is 0 it means no cache, use new StringWriter #24274
Merged
erickgonzalez added a commit that referenced this issue Mar 7, 2023
@erickgonzalez
#24247 if ttl is 0 it means no cache, use new StringWriter (#24274)
ca4f081
@erickgonzalez erickgonzalez reopened this Mar 7, 2023
@erickgonzalez
Copy link
Contributor Author

The customer tested the fix and confirmed that is working as it should.

@josemejias11
Copy link

josemejias11 commented Apr 24, 2023 •
edited

QA Not Needed

Costumer confirmed fix is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickgonzalez erickgonzalez

Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott Priority : 1 Show Stopper QA : Not Needed Release : 23.01.1 Included in LTS patch release 23.01.1 Release : 23.05 Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#24247 if ttl is 0 it means no cache, use new StringWriter dotCMS/core
4 participants
@bryanboza @erickgonzalez @damen-dotcms @josemejias11