Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfolders in Site Browser are not sorted alphabetically if the folder Name is changed #20104 #24482

Closed
MarkMarkham2 opened this issue Mar 24, 2023 · 3 comments · Fixed by #26281
Assignees
Labels
Next LTS Release Shortlisted of issues that will be included in the upcoming LTS OKR : Customer Support Owned by Scott Priority : 4 Low QA : Approved Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@MarkMarkham2
Copy link

Parent Issue

No response

Problem Statement

Subfolders in Site Browser are not sorted alphabetically if the folder Name is changed #20104

Steps to Reproduce

To Reproduce
Steps to reproduce the behavior:
Create a folder at root level
Create a few sub folders where the Titles and Names agree
They appear to be sorted alphabetically sorted
Add another folder where the Title and Name are different
The folder is sorted by Title not Name
Browser folder tree
Site or Folder tree

reported and verified in https://dotcms.zendesk.com/agent/tickets/110684

Acceptance Criteria

all folders even if renamed should be sorted alphabetically

dotCMS Version

PLATFORM EDITION: 23.01

Proposed Objective

Customer Support

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

reported and verified in https://dotcms.zendesk.com/agent/tickets/110684

https://dotcms.slack.com/archives/C028Z3R2D/p1679676989653299

Assumptions & Initiation Needs

reported fixed in #20104
but this view was over looked
Site or Folder tree

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@AndreyDotcms
Copy link
Contributor

AndreyDotcms commented Oct 24, 2023

Note for QA:

This sort order should also apply for BrowserResource.java hit the endpoint called /v1/browser with post method.
On the body add the parent's folder id hostFolderId. It should return the subfolders sorted alphabetically.

github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2023
* #24482 adding sorting fix

* #24482 adding test

* #24482 adding postman tests BrowserResource

* #24482 adding it tests, refactoring solution

---------

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@erickgonzalez erickgonzalez reopened this Nov 7, 2023
@erickgonzalez
Copy link
Contributor

erickgonzalez commented Nov 9, 2023

Working as it should, now the site selector is sort by folder name (the same sort as the Site Browser)
Screenshot 2023-11-09 at 3 51 13 PM

@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

@bryanboza bryanboza added the Release : 23.12.21 SEO Improvements label Dec 22, 2023
@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS and removed LTS : Next Ticket that will be added to LTS labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next LTS Release Shortlisted of issues that will be included in the upcoming LTS OKR : Customer Support Owned by Scott Priority : 4 Low QA : Approved Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants