Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes in Angular #24486

Closed
Tracked by #24317
fmontes opened this issue Mar 24, 2023 · 5 comments · Fixed by #24487
Closed
Tracked by #24317

UI fixes in Angular #24486

fmontes opened this issue Mar 24, 2023 · 5 comments · Fixed by #24487

Comments

@fmontes
Copy link
Member

fmontes commented Mar 24, 2023

Parent Issue

#24317

Problem Statement

Fix the list of the UI issues in Angular:

image

- Make it wider to read the full text. - Check if we can make it to fit the text, maybe using `fit-content`

image

  • Make it rounded, external use the md variables
  • Internal boxes the sm variable

image

  • Use md variable for both
  • See if in the top module you can use overflow: hidden and round the wrapper box

image

  • Center the lock icon

Steps to Reproduce

N/A

Acceptance Criteria

N/A

dotCMS Version

master

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@zJaaal zJaaal self-assigned this Mar 24, 2023
@fmontes fmontes removed the Triage label Mar 24, 2023
@zJaaal zJaaal linked a pull request Mar 24, 2023 that will close this issue
3 tasks
fmontes pushed a commit that referenced this issue Mar 27, 2023
* fix UI in Angular

* fix broken test
@fmontes fmontes self-assigned this Mar 30, 2023
@fmontes
Copy link
Member Author

fmontes commented Mar 30, 2023

Looks good to me... the lock icon could be 0.5px more centered, but is fine.

@wezell
Copy link
Contributor

wezell commented Apr 4, 2023

Needs Work - we are hiding the content type variable names which is really primary information

Screen Shot 2023-04-04 at 3 53 34 PM

@wezell wezell reopened this Apr 4, 2023
@zJaaal
Copy link
Contributor

zJaaal commented Apr 4, 2023

The variable can be seen if you hover in the button, it's showed in a tooltip.

Actually there's a whole redesign of that component in this PR.

It is actually done, but I drafted that PR because I saw the opportunity to refactor an old button that was being used in that component, but is a really old button and it's being used in several places so I'm not sure about that refactor. So I'm waiting for Freddy to evaluate that

@fmontes
Copy link
Member Author

fmontes commented Apr 10, 2023

@wezell we're working that in here: #23816

@josemejias11
Copy link

Approved QA - Tested on 23.05_f6363d0c_SNAPSHOT // Docker // macOS 13.0 // FF v111.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment