Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Favorite Pages: Browsing in Edit mode lost track of Favorite Pages #24568

Closed
jgambarios opened this issue Apr 5, 2023 · 2 comments · Fixed by #24932
Closed

UI - Favorite Pages: Browsing in Edit mode lost track of Favorite Pages #24568

jgambarios opened this issue Apr 5, 2023 · 2 comments · Fixed by #24932

Comments

@jgambarios
Copy link
Contributor

jgambarios commented Apr 5, 2023

Parent Issue

#22343

Problem Statement

In edit mode, saving a page A as Favorite Page, then browsing inside the edit mode, to a different page, when we come back to page A, the UI does not mark page A as a Favortite Page.

As the UI does not recognize page A as a Favortite Page we can add it again, ending up with two Favorite Pages of the same page.

2023-04-05_09-26-56 (1)

Steps to Reproduce

  1. Go to a page in edit mode
  2. Add the page as Favorite Page
  3. In the edit mode, browse to a different page and then come back to the initial page
  4. The page is not marked as Favorite Page

Acceptance Criteria

Even when browsing inside the edit mode, the Favorite Page "status" should be handled and Favorite Pages should be marked as such.

dotCMS Version

23.05_86e392fc_SNAPSHOT

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

@alfredo-dotcms alfredo-dotcms self-assigned this May 12, 2023
alfredo-dotcms added a commit that referenced this issue May 16, 2023
alfredo-dotcms added a commit that referenced this issue May 16, 2023
alfredo-dotcms added a commit that referenced this issue May 16, 2023
fmontes pushed a commit that referenced this issue May 17, 2023
* #24568 fix Favorite Pages: Browsing in Edit mode lost track of Favorite Pages

* #24568 fix Favorite Pages: Browsing in Edit mode lost track of Favorite Pages - feedback

* #24568 fix Favorite Pages: Browsing in Edit mode lost track of Favorite Pages - feedback v2
@zJaaal zJaaal self-assigned this May 17, 2023
@zJaaal
Copy link
Contributor

zJaaal commented May 17, 2023

Passed Internal QA

Docker Image: [dotcms/dotcms:23.06_8b14ad11_SNAPSHOT]

Screenshots

Screen.Recording.2023-05-17.at.2.34.49.PM.1.mov

@josemejias11
Copy link

Approved QA - Tested on 23.06_1d391801_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment