Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot push publish to S3 buckets in the us-east-2 region #24698

Closed
7 tasks done
swicken-dotcms opened this issue Apr 19, 2023 · 6 comments · Fixed by #27367
Closed
7 tasks done

Cannot push publish to S3 buckets in the us-east-2 region #24698

swicken-dotcms opened this issue Apr 19, 2023 · 6 comments · Fixed by #27367
Assignees
@erickgonzalez
Labels
OKR : Customer Success Owned by Arno OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.16 Included in LTS patch release 23.01.16 Release : 23.10.24 v9 Included in LTS patch release 23.10.24 v9 Release: 24.03.11 Bug Fixing Team : Bug Fixers Type : Defect

Comments

@swicken-dotcms
Copy link
Contributor

swicken-dotcms commented Apr 19, 2023 •
edited by erickgonzalez

Parent Issue

No response

Problem Statement

When you attempt to push publish to S3 buckets in us-east-2/eu-central-1 you get a return of '400 bad request'. This appears to occur in the deprecated function 'doesBucketExist'.

AWS logs show this as a malformed authorization header.

According to cloud this could be due to a couple of reasons

  1. us-east-2/eu-central-1 is the only US region that supports Signature Version 4 only (does not support both Version 2 and Version 4), this seems the most likely cause since it's claiming our header is malformed.
  2. We might not be using region specific endpoints

Steps to Reproduce

  1. Create an S3 bucket in the us-east-2 region/eu-central-1
  2. Configure PP to push to that bucket
  3. Attempt to push to the bucket
  4. Get a 400 bad request.

Acceptance Criteria

You should be able to push to buckets in all AWS regions. Let's test against:

  • eu-central-1
  • eu-west-1
  • us-east-1
  • us-east-2
  • us-west-1
  • us-west-2
  • ca-central-1

dotCMS Version

23.03, 23.01

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

Update the doesBucketExist call to use doesBucketExistV2

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jul 19, 2023
@swicken-dotcms
Copy link
Contributor Author

This is not stale

@wezell
Copy link
Contributor

wezell commented Jul 24, 2023

#22449 did not fix the issue?

@swicken-dotcms
Copy link
Contributor Author

swicken-dotcms commented Dec 8, 2023 •
edited

@wezell no it did not, I believe its because we did not update our call to doesBucketExist as I put in my acceptance criteria

https://dotcms.zendesk.com/agent/tickets/114366 ticket on 23.10.24

@erickgonzalez erickgonzalez self-assigned this Jan 18, 2024
erickgonzalez added a commit that referenced this issue Jan 18, 2024
@erickgonzalez
fix(static-push): use doesBucketExistV2 ref: #24698
4d362bf
@erickgonzalez erickgonzalez linked a pull request Jan 20, 2024 that will close this issue
fix(static-push): use doesBucketExistV2 ref: #24698 #27367
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 20, 2024
@erickgonzalez
fix(static-push): use doesBucketExistV2 ref: #24698 (#27367)
52eaaa9 
* fix(static-push): use doesBucketExistV2 ref: #24698

* test: ignore test since it's no longer valid
@erickgonzalez erickgonzalez reopened this Jan 20, 2024
@dsolistorres
Copy link
Contributor

Internal QA passed: bundle successfully was push published to S3 bucket in us-east-2 region

image

@bryanboza
Copy link
Member

Fixed, tested on the last master and now it is working as expected

@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Mar 11, 2024
@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS and removed LTS : Next Ticket that will be added to LTS labels Apr 23, 2024
erickgonzalez added a commit that referenced this issue May 1, 2024
@erickgonzalez
#24698 include in 23.10.24
dfd8122
@erickgonzalez erickgonzalez added the Release : 23.10.24 v9 Included in LTS patch release 23.10.24 v9 label May 1, 2024
erickgonzalez added a commit that referenced this issue May 2, 2024
@erickgonzalez
#24698 include in 23.01.16
bcd25f5
@erickgonzalez erickgonzalez added Release : 23.01.16 Included in LTS patch release 23.01.16 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickgonzalez erickgonzalez

Labels
OKR : Customer Success Owned by Arno OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.16 Included in LTS patch release 23.01.16 Release : 23.10.24 v9 Included in LTS patch release 23.10.24 v9 Release: 24.03.11 Bug Fixing Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(static-push): use doesBucketExistV2 ref: #24698 dotCMS/core
5 participants
@wezell @bryanboza @dsolistorres @erickgonzalez @swicken-dotcms