Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Undo/Redo Issues in Block Editor #24716

Closed
fmontes opened this issue Apr 21, 2023 · 3 comments · Fixed by #24728
Closed

Fix Undo/Redo Issues in Block Editor #24716

fmontes opened this issue Apr 21, 2023 · 3 comments · Fixed by #24728
Assignees
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.01.6 Included in LTS patch release 23.01.6 Release : 23.05 Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Apr 21, 2023

Problem Statement

In the block editor, when a user hits ctrl+z to undo an action, it does not work as expected because the updateChartCount add entries to this history on every keystroke.

Steps to Reproduce

  1. Navigate to the block editor
  2. Type some words
  3. Hit ctrl+z to undo the change

Acceptance Criteria

  1. We need to find a way to updateChartCount without adding steps to the ctrl+z history.
  2. ctrl+z should work for text and words
  3. The editor isEmpty should work correctly.

External Links

N/A

Assumptions & Initiation Needs

N/A

Quality Assurance Notes & Workarounds

N/A

@fmontes
Copy link
Member Author

fmontes commented Apr 25, 2023

Note to QA:

  1. The command Z is time based, means that the editor save data debounced
  2. Make sure you check the editor empty, like when is required and is empty
  3. Make sure it saves the information about char count etc in the DB (use the API)
  4. Tests languages and history that content is getting saved correctly.
  5. Also tests that if you open a contentlet and the block editor is not touched but have content still saves correctly.

@josemejias11
Copy link

Approved QA - Tested on 23.05_ea5adb9f_SNAPSHOT // Docker // macOS 13.0 // FF v112.0.1

@dsilvam dsilvam closed this as completed in 4cd0d90 May 1, 2023
@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS Next LTS Release LTS: Excluded Ticket that has been excluded from at least one LTS and removed LTS : Next Ticket that will be added to LTS labels Aug 8, 2023
@erickgonzalez
Copy link
Contributor

Only for 23.01 LTS

erickgonzalez added a commit that referenced this issue Aug 17, 2023
@erickgonzalez erickgonzalez added Release : 23.01.6 Included in LTS patch release 23.01.6 and removed Next LTS Release labels Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.01.6 Included in LTS patch release 23.01.6 Release : 23.05 Team : Lunik Type : Defect
Projects
Archived in project
5 participants