Remove ReloadableServletContainer

[nollymar]

Parent Issue

No response

Task

The ReloadableServletContainer must be removed. @spbolton implemented most of the changes on this branch.

What is missing here:

• Update the branch
• Remove the reference of the ReloadableServletContainer from the web.xml
• Testing

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

[dcolina]

Needs work.

If you load the REST plugin via web application, it does not appear in the plugin listing, even by forcing a refresh or restarting the framework.

In addition to appearing in the plugin listing, it should be possible to hit the endpoints exposed by the plugin, but these are not available.

See how it should look. This is an example on demo site:

On the other hand, no error is seen in the log traces.

PD:

For testing I'm using com.dotcms.rest

[spbolton]

@dcolina
Are you running this through the deployWarTomcat with gradle, or through docker container. Does any plugin load, I was testing through the maven build and it was working fine. It maybe the local configuration that the plugin file is not getting dynamically loaded correctly could be configuration of the felix folders which would make sense if you are not seeing any logs as it would not even be attempting to start.

[dcolina]

Hi Steve, I found that I was having problems with the environment, so the first tests are not valid. I completely restored the local environment, I even had to reboot the laptop to reliably repeat the tests.

Once the local environment was restored, I repeated the above test, adding and removing plugins, and found no errors. You can also see how the added plugins are listed and the endpoints exposed by that plugin can be called.

I followed these steps:

1. Launch the application
2. Go to the Plugins section and select Add +.
3. Select the appropriate plugin and click the Upload button.
4. When the upload process is finished, the newly added plugin should be listed in the central panel.
5. You will be able to perform actions such as start, stop, undeploy on the plugin.
6. Repeat steps i - iv with a REST type plugin to test its functionality.
7. Once deployed, you will be able to call its exposed REST methods (for the example I tested with the com.dotcms.rest plugin, I called the POST and PUT methods, as you can read in the README file).
8. No errors are detected, so the internal QA is approved.

Internal QA passed

[josemejias11]

Approved QA - Tested on master_pre-release_23.08_8d30d6e // Docker // macOS 13.0 // FF v113.0