Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Builder: Small Errors on Component Box #25110

Closed
Tracked by #24535
zJaaal opened this issue Jun 1, 2023 · 0 comments · Fixed by #25117
Closed
Tracked by #24535

Template Builder: Small Errors on Component Box #25110

zJaaal opened this issue Jun 1, 2023 · 0 comments · Fixed by #25117
Assignees
@zJaaal
Labels
Priority : 3 Average QA : Not Needed Release : 23.08.16 Team : Lunik Type : Defect

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Jun 1, 2023 •
edited

Parent Issue

No response

Problem Statement

The Box component of the Template Builder has some small TypeScript Errors and Lint errors.

Steps to Reproduce

  1. Go to core-web/libs/template-builder/src/lib/components/template-builder/components/template-builder-box/template-builder-box.component.html

  2. Look how the Editor shows error messages

Acceptance Criteria

  • Box Component should compile
  • Box Component code shouldn't have errors in the code
  • Box Component should have test for it's events

dotCMS Version

master

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@zJaaal zJaaal self-assigned this Jun 1, 2023
@zJaaal zJaaal linked a pull request Jun 1, 2023 that will close this issue
Fix #25110: Fix Small TS, Lint and Styles issues on Template Builder Box Component #25117
Merged
fmontes pushed a commit that referenced this issue Jun 2, 2023
@zJaaal
Fix #25110: Fix Small TS, Lint and Styles issues on Template Builder …
edf4788 
…Box Component (#25117)

* fix typescript and lint errors

* small fix on styles

* add tests for events

* use rem values

* fix test feedback

* rename interface
manuelrojas pushed a commit that referenced this issue Jun 2, 2023
@zJaaal @manuelrojas
Fix #25110: Fix Small TS, Lint and Styles issues on Template Builder …
7d8a285 
…Box Component (#25117)

* fix typescript and lint errors

* small fix on styles

* add tests for events

* use rem values

* fix test feedback

* rename interface
This was referenced Jun 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
Priority : 3 Average QA : Not Needed Release : 23.08.16 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
3 participants
@fmontes @zJaaal @damen-dotcms