Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite Pages: 'Last Edited' date displays incorrectly when editing or creating any file #25626

Closed
josemejias11 opened this issue Jul 26, 2023 · 4 comments · Fixed by #25682
Closed

Favorite Pages: 'Last Edited' date displays incorrectly when editing or creating any file #25626

josemejias11 opened this issue Jul 26, 2023 · 4 comments · Fixed by #25682
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.09.6 Release Template Builder Team : Lunik Type : Defect

Comments

@josemejias11
Copy link

josemejias11 commented Jul 26, 2023 •
edited

Parent Issue

[Pages]

Problem Statement

When editing or creating any file, the last edit date does not display correctly.

Steps to Reproduce

  1. Go to https://localhost:8443/dotAdmin/#/pages
  2. Create or edit a file
  3. Observe that the displayed last edit date does not reflect the actual date/time of the edit

Acceptance Criteria

When a file is edited or created, the last edit date should accurately reflect the date and time of the most recent modification.

dotCMS Version

23.07

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

Screenshot 2023-07-26 at 9 17 27 AM

Sub-Tasks & Estimates

No response
@fmontes fmontes changed the title ' Last Edited ' date displays incorrectly when editing or creating any file Favorite Pages: 'Last Edited' date displays incorrectly when editing or creating any file Jul 28, 2023
@fmontes
Copy link
Member

fmontes commented Aug 1, 2023

Maybe related to this? #25293

@zJaaal zJaaal self-assigned this Aug 1, 2023
@zJaaal
Copy link
Contributor

zJaaal commented Aug 1, 2023

After more research, is related to an issue with how we manage the Timezones in the frontend. Working on it

@zJaaal zJaaal linked a pull request Aug 1, 2023 that will close this issue
Fix #25626: Favorite Pages Unify Relative Date Calculation To One Single Pipe #25682
Merged
@fmontes
Copy link
Member

fmontes commented Aug 2, 2023

We'll be unifying the the date pipes

fmontes pushed a commit that referenced this issue Aug 14, 2023
@zJaaal
Fix #25626: Favorite Pages Unify Relative Date Calculation To One Sin…
f1445e2 
…gle Pipe (#25682)

* fix date parsing

* fix default value of service

* change approach

* refactor of dotRelativePipe to use it across the project

* clean comments

* fix tests

* small clean up

* code cleaning

* enhance tests

* fix broken tests

* enhance comments

* feedback (dotRelativePipe Tests): delete unnecessary tests and rename constants
@josemejias11 josemejias11 reopened this Aug 14, 2023
@josemejias11
Copy link
Author

Approved QA - Tested on master_792865e_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

@josemejias11 josemejias11 added QA : Approved Release : 23.09.6 Release Template Builder labels Aug 22, 2023
@fmontes fmontes closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 23.09.6 Release Template Builder Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #25626: Favorite Pages Unify Relative Date Calculation To One Single Pipe dotCMS/core
3 participants
@fmontes @zJaaal @josemejias11