Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Empty Starter] : The Language Variable Content Type is not visible from the Content portlet #25891

Closed
jcastro-dotcms opened this issue Aug 24, 2023 · 6 comments · Fixed by #27487
Assignees
Labels
dotCMS : Content Management LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott QA : Approved Release : 23.01.13 Included in LTS patch release 23.01.13 Release : 23.10.24 v6 Included in LTS patch release 23.10.24 v6 Release : 24.02.20 New binary field, AI plugin Team : Bug Fixers Triage Type : Defect

Comments

@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Aug 24, 2023

Problem Statement

In the Empty Starter, the Language Variable type is marked as a system type. This is incorrect, and is NOT set as system in the Full Starter. A new Empty Starter must be generated.

Steps to Reproduce

  1. Start up dotCMS with the latest master branch using the Empty Starter.
  2. Go to the Schema > Content Types portlet to make sure that the Language Variable type is there.
  3. Go to the Content > Search portlet and click the Type dropdown.
  4. You will NOT see the Language Variable type in there.

Acceptance Criteria

The Language Variable type is NOT a system type, and should be accessible for Users to create contents of such a type.

Create a UT that marks the Language Variable Content Type as system = false and also update our starter, doing this would require our current customers in 23.10 LTS that do a reindex so this content will show.

dotCMS Version

Latest master, 23.06, and probably older versions.

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

@wezell
Copy link
Contributor

wezell commented Aug 24, 2023

@jcastro-dotcms - I think it should be a system type. Happy to discuss.

@john-thomas-dotcms
Copy link
Contributor

@wezell the reason this came up is because, in the empty starter, the Language Variable content type doesn't show up in the Content Search screen. It just doesn't appear in the Type drop-down, because, as a system type, it's hidden.

This is the part that seems like it's not working as expected. I think if it could be changed from a system type to a normal type, it wouldn't be a problem. But from my understanding, that's not possible without directly changing the DB. And that doesn't seem like a good pattern to have.

@wezell wezell added the dotCMS : Localization Includes i18n and multi-lingual issues label Sep 19, 2023
@wezell
Copy link
Contributor

wezell commented Sep 19, 2023

@damen-dotcms Standardizing on using the languageVariable content type for all language props should be part of the multi-lingual initiative.

@erickgonzalez
Copy link
Contributor

Customer hitting this: https://dotcms.zendesk.com/agent/tickets/114941

@erickgonzalez erickgonzalez added Team : Bug Fixers OKR : Customer Support Owned by Scott and removed Team : Scout dotCMS : Localization Includes i18n and multi-lingual issues labels Jan 24, 2024
@erickgonzalez erickgonzalez self-assigned this Jan 24, 2024
@erickgonzalez erickgonzalez linked a pull request Feb 5, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
* fix(upgradetask): create new upgrade task to update system value ref:#25891

* test: upgrade task test ref:#25891

* refactor: rename property ref:#25891

* test: add test to mainsuite ref:#25891

* fix: update empty starter ref:#25891

* fix tests

* fix(tests): create content type if doesn't exist ref: #25891
@josemejias11
Copy link

Approved: Tested on master_8e38971, Docker, macOS 13.0, FF v121.0.1
Screenshot 2024-02-16 at 10 59 39 AM

@josemejias11 josemejias11 added the Release : 24.02.20 New binary field, AI plugin label Feb 16, 2024
@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Feb 16, 2024
@erickgonzalez erickgonzalez added the LTS: Excluded Ticket that has been excluded from at least one LTS label Feb 28, 2024
@erickgonzalez
Copy link
Contributor

Not Apply for 23.01 LTS

@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS Release : 23.01.13 Included in LTS patch release 23.01.13 and removed LTS : Next Ticket that will be added to LTS labels Feb 28, 2024
erickgonzalez added a commit that referenced this issue Mar 5, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v6 Included in LTS patch release 23.10.24 v6 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotCMS : Content Management LTS: Excluded Ticket that has been excluded from at least one LTS OKR : Customer Support Owned by Scott QA : Approved Release : 23.01.13 Included in LTS patch release 23.01.13 Release : 23.10.24 v6 Included in LTS patch release 23.10.24 v6 Release : 24.02.20 New binary field, AI plugin Team : Bug Fixers Triage Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants