Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :persona from tag when doing ES #26158

Closed
erickgonzalez opened this issue Sep 18, 2023 · 3 comments · Fixed by #26240
Closed

Remove :persona from tag when doing ES #26158

erickgonzalez opened this issue Sep 18, 2023 · 3 comments · Fixed by #26240
Assignees
Labels

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Sep 18, 2023

Parent Issue

#22872

Problem Statement

When doing an ES query, if the content has a TAG field and one of the tags is a persona, we add :persona to the tag. This is confusing since we get rid of the :persona tags.

Steps to Reproduce

1- Create a Content Type (TestTags) with a tag field (tags)
2- Create a persona (personatag)
3- Create a content of TestTags and add the personatag.
4- Go to the ES Query Portlet and run:

{
"query" :
{
"query_string" :
{
"query" : "+contentType:TestTags +TestTags.tags:(\"personatag\")"
}
},
"size":10
}

Acceptance Criteria

Since we removed the :persona tags, this should not be appended.

dotCMS Version

22.03+

Proposed Objective

Customer Support

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/108233

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@erickgonzalez erickgonzalez self-assigned this Sep 18, 2023
erickgonzalez added a commit that referenced this issue Sep 18, 2023
erickgonzalez added a commit that referenced this issue Sep 22, 2023
erickgonzalez added a commit that referenced this issue Sep 22, 2023
@erickgonzalez erickgonzalez linked a pull request Sep 22, 2023 that will close this issue
erickgonzalez added a commit that referenced this issue Sep 26, 2023
* test: create test
Ref: #26158

* chore: remove append of :persona
Ref: #26158

---------

Co-authored-by: Will Ezell <will@dotcms.com>
@erickgonzalez erickgonzalez reopened this Sep 26, 2023
erickgonzalez added a commit that referenced this issue Sep 28, 2023
@erickgonzalez erickgonzalez added Release : 23.01.7 Included in LTS patch release 23.01.7 and removed Next LTS Release labels Sep 28, 2023
@josemejias11
Copy link

Failed: Tested on master_d0f3abe_SNAPSHOT, Docker, macOS 13.0, FF v113.0
Screenshot 2023-09-29 at 1 56 13 PM

Query is still showing relation to personatag

@erickgonzalez
Copy link
Contributor Author

@josemejias11 It's working in your screenshot. You can't see the :persona not longer happening.

Before:
Screenshot 2023-10-02 at 5 31 53 PM

After:
Screenshot 2023-10-02 at 5 34 26 PM

@josemejias11
Copy link

Approved: Tested on master_d0f3abe_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants