Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub Connection should prefer SSL #26481

Closed
wezell opened this issue Oct 20, 2023 · 1 comment · Fixed by #26487
Closed

Pubsub Connection should prefer SSL #26481

wezell opened this issue Oct 20, 2023 · 1 comment · Fixed by #26487
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 22.03.12 Included in LTS patch release 22.03.12 Release : 23.01.9 Included in LTS patch release 23.01.9 Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Oct 20, 2023 •
edited

Parent Issue

No response

Problem Statement

The pgjdbc-ng driver/connection we use for pubsub does not force SSL connections to the postgres database. When upgrading our RDS instances to use postgres 15.4 the PubSub failed to connect. You can fix this by adding
?ssl.mode=prefer that will tell the connection to prefer SSL.

Steps to Reproduce

Try running dotCMS against a postgres instance that does not allow non-ssl connections

Acceptance Criteria

PubSub needs to autowire correctly.

dotCMS Version

23.10

Proposed Objective

Cloud Engineering

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
wezell added a commit that referenced this issue Oct 20, 2023
@wezell
fix(db) adding ssl.mode=require to the PubSub connection
0780f2e 
ref: #26481
wezell added a commit that referenced this issue Oct 20, 2023
@wezell
fix(db) adding ssl.mode=require to the PubSub connection
9ed6f17 
ref: #26481
wezell added a commit that referenced this issue Oct 20, 2023
@wezell
fix(db) adding ssl.mode=require to the PubSub connection
1e9eb6a 
ref: #26481
@wezell wezell changed the title Force Pubsub Connection to SSL Pubsub Connection should prefer SSL Oct 20, 2023
@erickgonzalez erickgonzalez added Priority : 2 High LTS : Next Ticket that will be added to LTS OKR : Customer Support Owned by Scott labels Oct 23, 2023
wezell added a commit that referenced this issue Oct 23, 2023
@wezell
fix(db) fixing tests
0b386b8 
ref: #26481
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2023
@wezell
Issue 26481 pubsub prefer ssl (#26487)
f96ef96 
* fix(db) adding ssl.mode=require to the PubSub connection

ref: #26481

* fix(db) adding ssl.mode=require to the PubSub connection

ref: #26481

* fix(db) adding ssl.mode=require to the PubSub connection

ref: #26481

* fix(db) fixing tests

ref: #26481
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Nov 20, 2023
erickgonzalez added a commit that referenced this issue Nov 20, 2023
@erickgonzalez
#26481 include in 23.01.9
425493e
@erickgonzalez erickgonzalez added Release : 23.01.9 Included in LTS patch release 23.01.9 Team : Bug Fixers and removed Triage labels Nov 27, 2023
@erickgonzalez erickgonzalez linked a pull request Nov 29, 2023 that will close this issue
Issue 26481 pubsub prefer ssl #26487
Merged
erickgonzalez added a commit that referenced this issue Dec 4, 2023
@erickgonzalez
#26481 include in 22.03.12
c140eb4
@erickgonzalez erickgonzalez added Release : 22.03.12 Included in LTS patch release 22.03.12 Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 and removed Next LTS Release labels Dec 4, 2023
erickgonzalez added a commit that referenced this issue Dec 5, 2023
@erickgonzalez
#26481 include in 23.10.24
9ddf536
@bryanboza
Copy link
Member

Fixed, tested starting the server using psql 15 with the single jdbc url:

 "DB_BASE_URL": "jdbc:postgresql://db/dotcms"

Now is not necessary add the ?ssl.mode=prefer to start

Tested on master // Docker // FF

@erickgonzalez erickgonzalez added LTS: Excluded Ticket that has been excluded from at least one LTS and removed LTS: Excluded Ticket that has been excluded from at least one LTS labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 22.03.12 Included in LTS patch release 22.03.12 Release : 23.01.9 Included in LTS patch release 23.01.9 Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 26481 pubsub prefer ssl dotCMS/core
3 participants
@wezell @bryanboza @erickgonzalez