Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic URLs encoding issue when configured by Vanity URL Redirect #26640

Closed
Neehakethi opened this issue Nov 8, 2023 · 8 comments · Fixed by #27132
Closed

Cyrillic URLs encoding issue when configured by Vanity URL Redirect #26640

Neehakethi opened this issue Nov 8, 2023 · 8 comments · Fixed by #27132
Assignees
Labels

Comments

@Neehakethi
Copy link
Contributor

Neehakethi commented Nov 8, 2023

Parent Issue

No response

Problem Statement

Cyrillic URL encoding issue, when configured by Vanity URL Redirect to an external Page.

When trying to pass Cyrcllic URL and configuring a vanity URL , The decoded characters are being passed wrongly to the external site

Steps to Reproduce

  1. Create a vanity URL on the demo site (Screenshot attached)
    image
  2. Try accessing https://demo.dotcms.com/test/%D0%BC%D0%B5%D1%82%D0%B0%D0%BB%D0%BD%D0%B0-%D0%BA%D0%B0[…]%BD%D0%B5%D0%B7%D0%B5-trender-%D0%B7%D0%B0-apple-watch-4041mm.
  3. It is being decoded wrongly as https://www.dotcms.com/destinations/???????-??????-???-????????-trender-??-apple-watch-4041mm
  4. This happens not to work if you forward to a page EXTERNALLY, if you self-reference the site in any way (including using demo.dotcms.com), it appears to work.
  5. In the vanity URL configuration, used dotcms.com, and you can see it ends up with an improperly encoded version

Acceptance Criteria

Decoding of write pattern should be sent to the external site

dotCMS Version

23.01.7
23.10.24

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/113992
https://dotcms.slack.com/archives/CSHTYUR7H/p1699379538799279

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@yolabingo
Copy link
Contributor

redirects from Rules using regex backreferences exhibit the same behavior

@binarybasher
Copy link

Is there any news or expected LTS release for this fix?

@erickgonzalez
Copy link
Contributor

Hi @binarybasher , one of our top developers is working on this, so we hope to have a fix soon. But it still needs to go through the whole process (merge PR -> Internal QA -> QA) to be included in an LTS release.

@binarybasher
Copy link

Thanks @erickgonzalez , do you have any ETA for the LTS release?

Thank you and Happy New Year!

@erickgonzalez
Copy link
Contributor

Hi @binarybasher ,

We hope that by the End of January, this fix will be included in all LTS releases.

Happy New Year.

github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
* fix(vanity-urls): Encode special charaters for vanity URL redirect targets (#26640)

* #26640 fixed url in test unit for send redirect action

* #26640 handled target url without explict protocol in vanity URL redirect

* #26640 throw exception for invalid url for tartet 301 redirect

---------

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@erickgonzalez erickgonzalez reopened this Jan 9, 2024
@erickgonzalez
Copy link
Contributor

Working as it should, now it's being decoded just fine.

Screenshot 2024-01-17 at 8 28 23 AM

@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS and removed Triage labels Jan 19, 2024
@binarybasher
Copy link

Thanks for the updates @erickgonzalez
Do you happen to know which LTS version this is likely to be included in?
Thanks

erickgonzalez added a commit that referenced this issue Jan 22, 2024
@erickgonzalez erickgonzalez added the Release : 23.01.11 Included in LTS patch release 23.01.11 label Jan 22, 2024
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Jan 26, 2024
erickgonzalez added a commit that referenced this issue Jan 26, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 and removed Next LTS Release labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants