Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Permissions Individually stuck when editing folder with legacy ID #26693

Closed
erickgonzalez opened this issue Nov 15, 2023 · 4 comments · Fixed by #26695
Closed

Edit Permissions Individually stuck when editing folder with legacy ID #26693

erickgonzalez opened this issue Nov 15, 2023 · 4 comments · Fixed by #26695
Assignees
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.11 Included in LTS patch release 23.01.11 Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Nov 15, 2023

Parent Issue

#18733

Problem Statement

Not able to Edit Permissions Individually of a folder if the inode is an old legacy one.

This is because of the changes we did, of removing the inheritance of Inode to Folders.

Steps to Reproduce

1- Include this property in the dotmarketing-config.properties dotshortyapi_use_legacy=true (need to restart the server)
1- Create a new Folder and a sub-folder
2- Insert a new inode into the inode table:

insert into inode(inode, idate, type) values('123456',now(),'folder');

3- change the inode of the parent folder created:

update folder set inode = '123456' where identifier = 'ID of Folder';

4- Flush Cache
5- Edit Edit Permissions Individually on the parent folder, e.g Add the Admin User and check a couple of items.
6- Sub-Folder should be getting permissions from parent Folder.
7- Try to Edit Permissions Individually on the sub-folder.

Acceptance Criteria

Should be able to Edit Permissions Individually even if the folder inode is an old legacy ID.

Also test, to Edit Permissions Individually to a new Folder with the new UUIDs.

dotCMS Version

23.01 LTS+

Proposed Objective

Customer Support

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/113937
https://dotcms.zendesk.com/agent/tickets/114019
https://dotcms.zendesk.com/agent/tickets/114182

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@erickgonzalez
Copy link
Contributor Author

Another customer: https://dotcms.zendesk.com/agent/tickets/114182

But this time, the folder had a new ID, but the sub-folder also inherited permissions from a parent folder. Also, test from the Users->Permissions Tab and Roles->Permissions Tab.

@josemejias11
Copy link

Approved: Tested on master_13c2337_SNAPSHOT, Docker, macOS 13.0, FF v113.0

@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Nov 30, 2023
@bryanboza bryanboza added Release : 23.12.21 SEO Improvements and removed Release 23.12.21 labels Dec 22, 2023
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Jan 8, 2024
erickgonzalez added a commit that referenced this issue Jan 20, 2024
@erickgonzalez erickgonzalez added the Release : 23.01.11 Included in LTS patch release 23.01.11 label Jan 23, 2024
@m27iu4
Copy link

m27iu4 commented Jan 24, 2024

@erickgonzalez customer is asking about estimated time they will have 23.01.11 applied to their dotCMS.
Do you have such info?
Thank you for your support, it is very appreciated!

@erickgonzalez
Copy link
Contributor Author

@m27iu4 23.01.11 is under QA right now, so if everything goes well, we expect to release it by Monday. And will be deployed in the next Maintenance Window.

erickgonzalez added a commit that referenced this issue Jan 26, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 and removed Next LTS Release labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.11 Included in LTS patch release 23.01.11 Release : 23.10.24 v3 Included in LTS patch release 23.10.24 v3 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants