Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text fields validation limit to 255 chars is not longer required #26774

Closed
weiyiwang-dotcms opened this issue Nov 20, 2023 · 7 comments · Fixed by #26938
Closed

text fields validation limit to 255 chars is not longer required #26774

weiyiwang-dotcms opened this issue Nov 20, 2023 · 7 comments · Fixed by #26938
Assignees
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 22.03.14 Included in LTS patch release 22.03.14 Release : 23.01.9 Included in LTS patch release 23.01.9 Release : 23.10.24 v4 Included in LTS patch release 23.10.24 v4 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect

Comments

@weiyiwang-dotcms
Copy link

weiyiwang-dotcms commented Nov 20, 2023

Parent Issue

No response

Problem Statement

When adding text to a text field in a contentlet, dotCMS enforces a 255 character limit for any content type. This affects any users who would like to add longer text information to content types, particularly for vanity URLs, where the URI and destination fields are already defined as text fields.

Steps to Reproduce

Add a new vanity URL
Try adding a long URI or long destination that is greater than 255 characters in length.
E.g

this-text-is-waaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaay-longer-than-two-hundred-fifty-five-characters-so-should-be-hitting-the-limit-for-the-fields-260-charsq

You will receive a popup modal that states you cannot add more than 255 characters

Acceptance Criteria

Remove the character limit validation for fields

dotCMS Version

Versions post implementation of contentlet_as_json

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/114171

https://dotcms.slack.com/archives/G01N0AU1NUC/p1700502221199139

Assumptions & Initiation Needs

The 255 character limit should no longer apply, since contentlet_as_json can store much more than 255 characters.

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@binarybasher
Copy link

Would this be solved by editing the "Vanity URL" Content Type and replacing the Text fields (URI, forwardTo) with TextArea fields?

@binarybasher
Copy link

We hit this issue with importing Vanity URLs, however no error was thrown.

@erickgonzalez
Copy link
Contributor

Hi @binarybasher,

Since those fields are required fields for the base-type Vanity URL can't be deleted. The validation is at the API so whichever path you try (REST API, UI, or Importing Content) this will be hit.

@binarybasher
Copy link

Thanks for confirming @erickgonzalez
It was worth a try, we have many Vanity URL's unable to work due to this and the Cyrillic issue.

@erickgonzalez erickgonzalez self-assigned this Nov 21, 2023
erickgonzalez added a commit that referenced this issue Nov 22, 2023
@erickgonzalez erickgonzalez added the Release : 23.01.9 Included in LTS patch release 23.01.9 label Nov 27, 2023
@erickgonzalez erickgonzalez linked a pull request Dec 8, 2023 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2023
* chore: remove 255 length validation ref: #26774

* test: test to validate removal of 255 length ref: #26774

* fix compile

* fix test
@erickgonzalez erickgonzalez reopened this Dec 11, 2023
@binarybasher
Copy link

It's not clear to me if this was resolved in 23.01.9 or if it's still open?

@erickgonzalez
Copy link
Contributor

Hi @binarybasher, this is resolved in 23.01.9 but the ticket is still open since we also fixed it in the master branch, and needs to be QA over there.

@josemejias11
Copy link

Approved: Tested on master_15e8ed4, Docker, macOS 13.0, FF v113.0

@bryanboza bryanboza added the Release : 23.12.21 SEO Improvements label Dec 22, 2023
erickgonzalez added a commit that referenced this issue Jan 9, 2024
@erickgonzalez erickgonzalez added the Release : 22.03.14 Included in LTS patch release 22.03.14 label Jan 12, 2024
@erickgonzalez erickgonzalez added Next LTS Release and removed LTS : Next Ticket that will be added to LTS labels Jan 30, 2024
erickgonzalez added a commit that referenced this issue Feb 16, 2024
erickgonzalez added a commit that referenced this issue Feb 16, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v4 Included in LTS patch release 23.10.24 v4 and removed Next LTS Release labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 22.03.14 Included in LTS patch release 22.03.14 Release : 23.01.9 Included in LTS patch release 23.01.9 Release : 23.10.24 v4 Included in LTS patch release 23.10.24 v4 Release : 23.12.21 SEO Improvements Team : Bug Fixers Type : Defect
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants