Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit Content" screen slow - Unnecessary SQL queries #26840

Closed
wezell opened this issue Nov 29, 2023 · 0 comments · Fixed by #26841
Closed

"Edit Content" screen slow - Unnecessary SQL queries #26840

wezell opened this issue Nov 29, 2023 · 0 comments · Fixed by #26841
Assignees
@fmontes
Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : User Experience Owned by Jason QA : Not Needed Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Team : Lunik Type : Defect

Comments

@wezell
Copy link
Contributor

wezell commented Nov 29, 2023 •
edited

Problem Statement

When we introduced the "Full Width Block or Text" field, we (I) wrote code that does a forward lookup looking to see if the next field on the same tab is a layout field or an entry field. The issue is that this lookup mistakenly bypasses the cached list of fields and instead does a number of fat SQL queries (buried in the API). This forward lookup code is called for every field (n+1 problem) so if you have a bunch of fields on a structure the page load gets slower and slower.

Steps to Reproduce

Open a contentlet for editing that has a a bunch of fields. You will see page performance suffer.

Acceptance Criteria

Loading the edit content screen should be fast.

dotCMS Version

23.10

Proposed Objective

Application Performance

Proposed Priority

Priority 1 - Show Stopper
@wezell wezell changed the title Unnecessary SQL queries on the "Edit Content" screen "Edit Content" screen slow - Unnecessary SQL queries Nov 29, 2023
wezell added a commit that referenced this issue Nov 29, 2023
@wezell
fix(perf) read field list from cache, not from sql
eb0d14e 
ref: #26840
github-merge-queue bot pushed a commit that referenced this issue Nov 30, 2023
@wezell
fix(perf) read field list from cache, not from sql (#26841)
a7af331 
ref: #26840
@erickgonzalez erickgonzalez added LTS : Next Ticket that will be added to LTS and removed Next LTS Release labels Nov 30, 2023
@erickgonzalez erickgonzalez linked a pull request Nov 30, 2023 that will close this issue
fix(perf) read field list from cache, not from sql #26841
Merged
@fmontes fmontes self-assigned this Dec 8, 2023
@fmontes fmontes closed this as completed Dec 8, 2023
@erickgonzalez erickgonzalez added Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 and removed LTS : Next Ticket that will be added to LTS labels Dec 13, 2023
erickgonzalez added a commit that referenced this issue Dec 13, 2023
@erickgonzalez
#26840 include in 23.10.24
8463e7f
@erickgonzalez erickgonzalez added Next LTS Release LTS: Excluded Ticket that has been excluded from at least one LTS and removed Next LTS Release labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

Labels
LTS: Excluded Ticket that has been excluded from at least one LTS OKR : User Experience Owned by Jason QA : Not Needed Release : 23.10.24 v1 Included in LTS patch release 23.10.24 v1 Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(perf) read field list from cache, not from sql dotCMS/core
4 participants
@fmontes @wezell @erickgonzalez @damen-dotcms