Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit EMA: Left Offsets are not working on React Library #27406

Closed
Tracked by #26644
zJaaal opened this issue Jan 23, 2024 · 7 comments · Fixed by #27408
Closed
Tracked by #26644

Edit EMA: Left Offsets are not working on React Library #27406

zJaaal opened this issue Jan 23, 2024 · 7 comments · Fixed by #27408

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Jan 23, 2024

Parent Issue

#26644

Problem Statement

We have an issue in the styles of our React SDK the left offsets are not being rendered as expected, we should respect the offsets that the users build in our template builder.

Steps to Reproduce

Here are the screenshots of the issue:

Layout

Screenshot 2024-01-23 at 12 48 42 PM

You can see that there's an offset between the columns

Editor

Screenshot 2024-01-23 at 12 49 37 PM

See in the editor how the offset is not where it should be

NextJS Page

Screenshot 2024-01-23 at 12 50 44 PM

And here we can see that the Next Page has the same issue

Acceptance Criteria

  • The offsets should render correctly in the Editor and in the Next Page

dotCMS Version

master - latest

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@zJaaal zJaaal self-assigned this Jan 23, 2024
@zJaaal zJaaal mentioned this issue Jan 23, 2024
@zJaaal zJaaal linked a pull request Jan 23, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2024
* fix start and end column for react styles

* fix test

* update package versions
@fmontes
Copy link
Member

fmontes commented Jan 23, 2024

We need to update the libraries and update the nextjs example to test this.

@zJaaal zJaaal changed the title Edit EMA: Left Offset are not working on React Library Edit EMA: Left Offsets are not working on React Library Jan 23, 2024
@KevinDavilaDotCMS
Copy link
Contributor

Passed Internal QA

Tested in Master

Screen.Recording.2024-01-25.at.17.30.41.mov

@bryanboza
Copy link
Member

we need some work here, seems we are not respecting the layout design

Screen.Recording.2024-02-21.at.2.13.50.PM.mov

@zJaaal
Copy link
Contributor Author

zJaaal commented Feb 21, 2024

@bryanboza can you provide the exact docker image you are using? Because I'm in dotcms/dotcms:master_07b2f28 and I'm not able to reproduce this.

Screen.Recording.2024-02-21.at.5.34.43.PM.mov

@zJaaal
Copy link
Contributor Author

zJaaal commented Feb 26, 2024

After some research I made. Looks like this issue and other ones are related to Vercel hosting cache. It does not send the new data that we modified in the editor but the cache it generated on first load. It looks like we can do something in our example to make it work, but we need to look for the best approach. This is not an issue or an error in the code but a problem with the hosting service we are using.

cc: @bryanboza @fmontes

@bryanboza bryanboza added Release: 24.03.11 Bug Fixing Release : 24.03.1 Announcements and removed Release : 24.03.1 Announcements labels Mar 1, 2024
@bryanboza bryanboza added Release : 24.03.22 Bug Fixing and removed Release: 24.03.11 Bug Fixing labels Mar 12, 2024
@fmontes
Copy link
Member

fmontes commented Mar 18, 2024

@bryanboza Updated the vercel deploy, working now.

@bryanboza
Copy link
Member

Fixed, tested on the last vercel server version and now this is working as expected, tested on qamaster server!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants