Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log too verbose in certain situations #27910

Closed
wezell opened this issue Mar 8, 2024 · 2 comments · Fixed by #28006
Closed

Log too verbose in certain situations #27910

wezell opened this issue Mar 8, 2024 · 2 comments · Fixed by #28006
Labels
OKR : Security & Privacy Owned by Mehdi QA : Approved Release : 22.03.15 Included in LTS patch release 22.03.15 Release : 23.01.15 Included in LTS patch release 23.01.15 Release : 23.10.24 v8 Included in LTS patch release 23.10.24 v8 Release : 24.03.22 Bug Fixing Team : Bug Fixers Triage Type : Defect Type : Task

Comments

@wezell
Copy link
Contributor

wezell commented Mar 8, 2024 •
edited by sfreudenthaler

Parent Issue

No response

Task

When logging command output, dotCMS can be too verbose and write unneeded detail into the log output.

Proposed Objective

Security & Privacy

Proposed Priority

Priority 2 - Important

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@wezell wezell changed the title Log to verbose in certain situations Log too verbose in certain situations Mar 8, 2024
@erickgonzalez erickgonzalez added Team : Bug Fixers LTS : Next Ticket that will be added to LTS labels Mar 12, 2024
wezell added a commit that referenced this issue Mar 18, 2024
@wezell
fix(log) only spit logs out if configured ref: #27910
4b62ca2
@erickgonzalez
Copy link
Contributor

PR: #28006

@sfreudenthaler sfreudenthaler linked a pull request Mar 20, 2024 that will close this issue
fix(log) only spit logs out if configured ref: #27910 #28006
Merged
wezell added a commit that referenced this issue Mar 20, 2024
@wezell
security(logging) can be overriden by env var
be8d64f 
ref: #27910
github-merge-queue bot pushed a commit that referenced this issue Mar 21, 2024
@wezell @erickgonzalez
fix(log) only spit logs out if configured ref: #27910 (#28006)
5eb7b2d 
* fix(log) only spit logs out if configured ref: #27910

* security(logging) can be overriden by env var

ref: #27910

---------

Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@erickgonzalez erickgonzalez reopened this Mar 21, 2024
@bryanboza
Copy link
Member

Fixed, tested before and after the fix and now we are just printing basic information

@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS and removed LTS : Next Ticket that will be added to LTS labels Apr 2, 2024
erickgonzalez added a commit that referenced this issue Apr 3, 2024
@erickgonzalez
#27910 include in 23.10.24
8347d10
erickgonzalez added a commit that referenced this issue Apr 4, 2024
@erickgonzalez
#27910 include in 23.01.15
a0f5272
erickgonzalez added a commit that referenced this issue Apr 5, 2024
@erickgonzalez
#27910 include in 22.03.15
5a486e4
@erickgonzalez erickgonzalez added Release : 23.01.15 Included in LTS patch release 23.01.15 Release : 22.03.15 Included in LTS patch release 22.03.15 Release : 23.10.24 v8 Included in LTS patch release 23.10.24 v8 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OKR : Security & Privacy Owned by Mehdi QA : Approved Release : 22.03.15 Included in LTS patch release 22.03.15 Release : 23.01.15 Included in LTS patch release 23.01.15 Release : 23.10.24 v8 Included in LTS patch release 23.10.24 v8 Release : 24.03.22 Bug Fixing Team : Bug Fixers Triage Type : Defect Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(log) only spit logs out if configured ref: #27910 dotCMS/core
4 participants
@wezell @bryanboza @erickgonzalez @sfreudenthaler