Created new Filter to intercept and normalizate URIs #17809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilvam
reviewed
Jan 10, 2020
dev-dotcms
reviewed
Jan 10, 2020
| } | ||
|
|
||
| @Override | ||
| public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| * invalids URIs | ||
| */ | ||
| @Test | ||
| public void test_uri_normalization_invalid_URI() throws IOException, ServletException { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| * valid URIs | ||
| */ | ||
| @Test | ||
| public void test_uri_normalization_valid_URI() throws IOException, ServletException { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| private void compare(final String originalURI, final String expectedNormalizedURI) | ||
| throws IOException, ServletException { | ||
|
|
||
| HttpServletRequest request = mock(HttpServletRequest.class); |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| } | ||
|
|
||
| @Override | ||
| public void destroy() { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| public class NormalizationFilter implements Filter { | ||
|
|
||
| @Override | ||
| public void init(FilterConfig filterConfig) throws ServletException { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| public class NormalizationFilter implements Filter { | ||
|
|
||
| @Override | ||
| public void init(FilterConfig filterConfig) throws ServletException { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
|
|
||
| @Override | ||
| public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, | ||
| FilterChain filterChain) throws IOException, ServletException { |
There was a problem hiding this comment.
dev-dotcms
reviewed
Jan 10, 2020
| public void doFilter(ServletRequest servletRequest, ServletResponse servletResponse, | ||
| FilterChain filterChain) throws IOException, ServletException { | ||
|
|
||
| HttpServletRequestWrapper requestWrapper = new HttpServletRequestWrapper( |
There was a problem hiding this comment.
dsilvam
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for ticket #17796
A filter was created to wrap all the incoming requests to override the
HttpServletRequest.getRequestURI()method in order to normalize all the requested URIs.