#21415 blocking remote calls to private subnets #21427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nollymar
requested changes
Jan 6, 2022
added 2 commits
January 6, 2022 15:43
…ssue-21415-xmltool
nollymar
approved these changes
Jan 7, 2022
erickgonzalez
approved these changes
Jan 7, 2022
freddyucv
reviewed
Jan 7, 2022
| } | ||
|
|
||
| @Test | ||
| public void test_xmltool_using_private_ip_should_throw_an_exception() { |
| } | ||
| } | ||
|
|
||
| @Test |
| setRoot(reader.read(url)); | ||
|
|
||
|
|
||
| if(IPUtils.isIpPrivateSubnet(url.getHost()) && !Config.getBooleanProperty("ALLOW_ACCESS_TO_PRIVATE_SUBNETS", false)){ |
There was a problem hiding this comment.
maybe we should use a util class for this logic, maybe in IPUtils
There was a problem hiding this comment.
probably in IPUtils
There was a problem hiding this comment.
I would encapsulate the Config call in a Lazy
freddyucv
approved these changes
Jan 7, 2022
jdotcms
reviewed
Jan 7, 2022
| @@ -193,6 +194,11 @@ public void doOut(final HttpServletResponse response) throws IOException { | |||
| .setConnectionRequestTimeout(Math.toIntExact(this.timeoutMs)) | |||
| .setSocketTimeout(Math.toIntExact(this.timeoutMs)).build(); | |||
| try (CloseableHttpClient httpclient = HttpClientBuilder.create().setDefaultRequestConfig(config).build()) { | |||
|
|
|||
| if(IPUtils.isIpPrivateSubnet(this.request.getURI().getHost()) && !Config.getBooleanProperty("ALLOW_ACCESS_TO_PRIVATE_SUBNETS", false)){ | |||
There was a problem hiding this comment.
I would encapsulate the Config call in a Lazy
jdotcms
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.