#22872 Avoid creation of duplicate persona tags #23848
Conversation
Postman Tests Report 54 files ±0 729 suites ±0 1h 31m 4s ⏱️ - 2m 10s For more details on these failures, see this check. Results for commit 8f1f482. ± Comparison against base commit a0734f8. ♻️ This comment has been updated with latest results. |
Integration Tests [postgres] Report 425 files ±0 425 suites ±0 1h 3m 32s ⏱️ - 7m 2s For more details on these failures, see this check. Results for commit 8f1f482. ± Comparison against base commit a0734f8. ♻️ This comment has been updated with latest results. |
| } | ||
|
|
||
| @Override | ||
| public String getMSSQLScript() { |
There was a problem hiding this comment.
Does this SQL work in MSSQL?
| @@ -75,7 +75,7 @@ public Tag getTagAndCreate ( String name, String hostId, boolean persona ) throw | |||
| } | |||
|
|
|||
| @Override | |||
| public Tag getTagAndCreate(final String name, final String userId, final String siteId, final boolean persona, final boolean searchInSystemHost) throws DotDataException, DotSecurityException { | |||
| public Tag getTagAndCreate(final String tagName, final String userId, final String siteId, final boolean persona, final boolean searchInSystemHost) throws DotDataException, DotSecurityException { | |||
|
|
|||
| boolean localTransaction = false; | |||
There was a problem hiding this comment.
Please remove the local transaction logic here and add the @WrapInTransaction annotation
|
SonarQube Quality Gate
|
| public Tag getTagAndCreate(final String name, final String userId, final String siteId, final boolean persona, final boolean searchInSystemHost) throws DotDataException, DotSecurityException { | ||
|
|
||
| boolean localTransaction = false; | ||
| @WrapInTransaction |
* #22872 Avoid creation of duplicate persona tags * #22872 remove dup line * #22872 Upgrade task to get rid of rels to dup tags, and dup tags per se * #22872 compile errors fix * #22872 IT for the UT * #22872 new method in TestDataUtil * #22872 delete with join for MSSQL. Add task to tasklocator. Add wrapIntransacton annotation
For specific reasons sometimes tags names are altered with a ":persona" suffix. This should not change the way some API methods behave.
This fix avoids creating a duplicate tag just because the persona suffix is added when calling the API method that creates the tag.
IT included.