Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23915 : Increase Password Hash Iterations #24035

Merged
merged 6 commits into from
Feb 10, 2023

Conversation

jcastro-dotcms
Copy link
Contributor

Proposed Changes

  • Increasing password hash iterations to 600,000 minimum. Updating the INFO message in the log to reflect the number of iterations.
  • Fixing the enumeration issue, as requested by @mbiuki .

* Increasing password hash iterations to 600,000 minimum. Updating the INFO message in the log to reflect the number of iterations.
* Fixing the enumeration issue, as requested by Mehdi.
@jcastro-dotcms jcastro-dotcms linked an issue Feb 3, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Unit Tests Report

1 418 tests  ±0   1 408 ✔️ ±0   3m 54s ⏱️ -2s
   140 suites ±0        10 💤 ±0 
   140 files   ±0          0 ±0 

Results for commit f6d73af. ± Comparison against base commit ceafccb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Postman Tests Report

     65 files  1 397 suites   3h 19m 21s ⏱️
   625 tests    623 ✔️ 0 💤 2
2 331 runs  2 324 ✔️ 0 💤 7

For more details on these failures, see this check.

Results for commit f6d73af.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Integration Tests [postgres] Report

   409 files     409 suites   1h 2m 41s ⏱️
3 899 tests 3 870 ✔️ 23 💤 6
3 920 runs  3 891 ✔️ 23 💤 6

For more details on these failures, see this check.

Results for commit f6d73af.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Integration Tests [mssql] Report

   408 files  ±0     408 suites  ±0   2h 39m 25s ⏱️ + 9m 53s
3 894 tests ±0  3 858 ✔️ +3  23 💤 ±0  13  - 3 
3 915 runs  ±0  3 879 ✔️ +3  23 💤 ±0  13  - 3 

For more details on these failures, see this check.

Results for commit f6d73af. ± Comparison against base commit ceafccb.

♻️ This comment has been updated with latest results.

@jcastro-dotcms
Copy link
Contributor Author

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@fmontes fmontes merged commit dcc9f8c into master Feb 10, 2023
@fmontes fmontes deleted the issue-23915-increase-hash-iterations branch February 10, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Password Hash Iterations
4 participants