Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotCMS/core#24172 Refresh Page portlet's data when site changed #24175

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,3 +1,5 @@
import { Subject } from 'rxjs';

import { Component, DebugElement, EventEmitter, Input, Output } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
Expand All @@ -11,6 +13,7 @@ import { DotMessageSeverity, DotMessageType } from '@components/dot-message-disp
import { DotMessageDisplayService } from '@components/dot-message-display/services';
import { DotRouterService } from '@dotcms/app/api/services/dot-router/dot-router.service';
import { DotEventsService } from '@dotcms/data-access';
import { mockSites, SiteService } from '@dotcms/dotcms-js';
import { dotcmsContentletMock, MockDotRouterService } from '@dotcms/utils-testing';

import { DotPageStore } from './dot-pages-store/dot-pages.store';
Expand Down Expand Up @@ -110,6 +113,8 @@ describe('DotPagesComponent', () => {
let dotRouterService: DotRouterService;
let dotMessageDisplayService: DotMessageDisplayService;

const switchSiteSubject = new Subject();

beforeEach(() => {
TestBed.configureTestingModule({
declarations: [
Expand All @@ -122,7 +127,19 @@ describe('DotPagesComponent', () => {
providers: [
DotEventsService,
{ provide: DotMessageDisplayService, useClass: DotMessageDisplayServiceMock },
{ provide: DotRouterService, useClass: MockDotRouterService }
{ provide: DotRouterService, useClass: MockDotRouterService },
{
provide: SiteService,
useValue: {
get currentSite() {
return undefined;
},

get switchSite$() {
return switchSiteSubject.asObservable();
}
}
}
]
}).compileComponents();
});
Expand Down Expand Up @@ -240,4 +257,10 @@ describe('DotPagesComponent', () => {
});
expect(store.getPages).toHaveBeenCalledWith({ offset: 0 });
});

it('should reload portlet only when the site change', () => {
switchSiteSubject.next(mockSites[0]); // setting the site
switchSiteSubject.next(mockSites[1]); // switching the site
expect(store.getPages).toHaveBeenCalledWith({ offset: 0 });
});
});
Expand Up @@ -5,12 +5,13 @@ import { Component, ElementRef, OnDestroy, OnInit, ViewChild } from '@angular/co
import { Menu } from 'primeng/menu';

import { Observable } from 'rxjs/internal/Observable';
import { filter, takeUntil } from 'rxjs/operators';
import { filter, skip, takeUntil } from 'rxjs/operators';

import { DotMessageSeverity, DotMessageType } from '@components/dot-message-display/model';
import { DotMessageDisplayService } from '@components/dot-message-display/services';
import { DotRouterService } from '@dotcms/app/api/services/dot-router/dot-router.service';
import { DotEventsService } from '@dotcms/data-access';
import { SiteService } from '@dotcms/dotcms-js';
import { DotCMSContentlet } from '@dotcms/dotcms-models';

import { DotPagesState, DotPageStore } from './dot-pages-store/dot-pages.store';
Expand Down Expand Up @@ -41,6 +42,7 @@ export class DotPagesComponent implements OnInit, OnDestroy {
private dotRouterService: DotRouterService,
private dotMessageDisplayService: DotMessageDisplayService,
private dotEventsService: DotEventsService,
private dotSiteService: SiteService,
private element: ElementRef
) {
this.store.setInitialStateData(FAVORITE_PAGE_LIMIT);
Expand Down Expand Up @@ -115,6 +117,10 @@ export class DotPagesComponent implements OnInit, OnDestroy {
type: DotMessageType.SIMPLE_MESSAGE
});
});

this.dotSiteService.switchSite$.pipe(takeUntil(this.destroy$), skip(1)).subscribe(() => {
this.store.getPages({ offset: 0 });
});
}

ngOnDestroy(): void {
Expand Down