-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-24093-Create_background_task_that_converts_fat_content_into_json_content #24615
Merged
nollymar
merged 9 commits into
master
from
issue-24093-Create_background_task_that_converts_fat_content_into_json_content
Apr 14, 2023
Merged
issue-24093-Create_background_task_that_converts_fat_content_into_json_content #24615
nollymar
merged 9 commits into
master
from
issue-24093-Create_background_task_that_converts_fat_content_into_json_content
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in case of errors, if everything goes well, the job is removed.
…t json with the data coming from the db
…t json with the data coming from the db
…background_task_that_converts_fat_content_into_json_content
…background_task_that_converts_fat_content_into_json_content
Postman Tests Report 66 files ±0 1 412 suites ±0 3h 36m 13s ⏱️ - 5m 28s For more details on these failures, see this check. Results for commit 1df7726. ± Comparison against base commit cffb861. ♻️ This comment has been updated with latest results. |
…d could cause issues and the value either way is always ignored, metadata is calculated directly from the asset.
…background_task_that_converts_fat_content_into_json_content
fabrizzio-dotCMS
approved these changes
Apr 14, 2023
nollymar
approved these changes
Apr 14, 2023
nollymar
deleted the
issue-24093-Create_background_task_that_converts_fat_content_into_json_content
branch
April 14, 2023 20:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at cfa302b
Summary
🧪🛠️⏱️
This pull request improves the JSON conversion and population of contentlets in dotCMS. It refactors the
ContentletTransformer
andPopulateContentletAsJSONJob
classes to fix some issues and simplify the logic. It also adds a new integration test classPopulateContentletAsJSONJobTest
to verify the functionality.Walkthrough
PopulateContentletAsJSONJob
class to use the standard Quartz API instead of the customDotStatefulJob
API (link, link, link, link)run
method to use thejobDataMap
to get theexcludingAssetSubType
parameter and to remove the job from the scheduler after execution (link, link)fireJob
method to create and schedule the job using aJobDetail
and aSimpleTrigger
object, and to check if the job already exists before scheduling it (link)removeJob
,getJobName
andgetJobGroupName
to support the new logic (link)HostAssetsJobProxy
class and add the imports of the classes and packages used in the new logic (link)ContentletTransformer
class to improve the performance and consistency of the JSON generation (link, link, link, link)ContentletTransformer
class, since it is not part of the contentlet table (link)setIdentifier
andsetInode
methods for readability (link)PopulateContentletAsJSONJobTest
to the integration-test package to test the logic of thePopulateContentletAsJSONJob
class (link)