Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24900 adds maxWidth and maxHeight support #24902

Merged
merged 7 commits into from Jul 11, 2023

Conversation

wezell
Copy link
Contributor

@wezell wezell commented May 10, 2023

This adds the following params:
for the /dA/ pathing adds mh and mw to specify maxHeight and maxWidth, e.g.

https://local.dotcms.site:8443/dA/2b100ac707/500mw/500mh

for the /contentAsset/image pathing, it adds resize_mh and resize_mw, e.g.

https://local.dotcms.site:8443/contentAsset/image/a196bf08-a1bd-4c1c-8709-786b6385545d/image/filter/Resize/resize_mw/500/resize_mh/500

@fmontes fmontes linked an issue Jun 13, 2023 that may be closed by this pull request
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 43.7% 43.7% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@wezell wezell merged commit d1ae95d into master Jul 11, 2023
25 of 30 checks passed
@wezell wezell deleted the issue-24900-maxwidth-maxheight branch July 11, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Resizer Improvements - specify maxWidth/maxHeight
4 participants