Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 23934 fix urlmap titles #25084

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

nollymar
Copy link
Contributor

This change is part of the fixes required after migrating to Tika 2.x. Specifically, it fixes an issue when site search indexes were generated. Particularly, titles weren't being resolved for urlMaps. It was happening because some keywords weren't being included by Tika, we had to add them all. A test was implemented to verify this case

daniel.colina and others added 2 commits May 30, 2023 09:33
…cies issue.

* SLF4J has been upgraded to 1.7.35
* org.apache.logging.log4j has been included as part of osgi-extra.conf to avoid dependency clashes inside of Tika Microsoft parsers.
@nollymar nollymar changed the base branch from master to release-23.06 May 30, 2023 21:04
@nollymar nollymar linked an issue May 30, 2023 that may be closed by this pull request
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And with a test! NICE.

@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@nollymar nollymar merged commit ec9b327 into release-23.06 May 31, 2023
11 of 20 checks passed
@nollymar nollymar deleted the issue-23934-fix-urlmap-titles branch May 31, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old Tika Version Pulling Wrong Width from Image for Metadata
3 participants