Fix #25341 Template Builder error when loading a template #25359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Generated by Copilot at 432e837
Summary
ππβ
Renamed and added outputs to template builder components to improve communication and consistency. Added a new test case and a new method to handle template updates and history reloads. Enhanced the template item object with
title
andwidth
properties.Walkthrough
updateTemplate
output toonTemplateItemChange
indot-template-builder-advanced
anddot-edit-layout-designer
components to avoid confusion with parent component output (link, link)onTemplateItemChange
method todot-template-builder.component.ts
to handle template item changes from both advanced and designer components, emit updated template item to parent component, and reload history iframe if it exists (link)ngOnChanges
method andOnChanges
interface fromdot-template-builder.component.ts
as they are no longer needed to reload history iframe (link, link, link)dot-template-builder.component.spec.ts
to verify thatonTemplateItemChange
method is called whenupdateTemplate
output ofdot-template-builder-advanced
component emits a value (link)dot-template-builder.component.spec.ts
to verify thatonTemplateItemChange
method is called whenupdateTemplate
output ofdot-edit-layout-designer
component emits a value (link, link)title
andwidth
properties to template item object that is emitted byTemplateBuilderComponent
intemplate-builder.component.ts
when layout changes, to match backend template item properties (link)Screenshots
Screen.Recording.2023-06-27.at.1.22.44.PM.mov