Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#25258 fix for adding images in non default language in WSYIWYG field #25370

Merged
merged 5 commits into from
Jun 29, 2023
Merged

#25258 fix for adding images in non default language in WSYIWYG field #25370

merged 5 commits into from
Jun 29, 2023

Conversation

dsolistorres
Copy link
Contributor

@dsolistorres dsolistorres commented Jun 27, 2023 •
edited

Proposed Changes

🤖 Generated by Copilot at c060e49

  • Added language parameter to fetch request for asset resource links in edit_field_js.jsp.
  • This ensures the WYSIWYG editor inserts the correct language version of an asset.

@dsolistorres dsolistorres marked this pull request as ready for review June 27, 2023 22:49
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@erickgonzalez erickgonzalez linked an issue Jun 29, 2023 that may be closed by this pull request
WYSIWYG not adding images when it's not default lang #25258
Closed
@erickgonzalez erickgonzalez merged commit ea101e4 into master Jun 29, 2023
25 of 32 checks passed
@erickgonzalez erickgonzalez deleted the issue-25258-fix-wysiwyg-images-for-non-default-lang branch June 29, 2023 22:33
manuelrojas pushed a commit that referenced this pull request Jul 5, 2023
@dsolistorres @manuelrojas
#25258 fix for adding images in non default language in WSYIWYG field (…
a8ecc1c 
…#25370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickgonzalez erickgonzalez erickgonzalez approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WYSIWYG not adding images when it's not default lang
3 participants
@dsolistorres @erickgonzalez @jcastro-dotcms